Add recipe for rl-games

[flferretti]

This is a recipe for rl-games pure-Python package.

PyPI: https://pypi.org/project/rl-games/
Repo: https://github.com/Denys88/rl_games

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rl-games) and found some lint.

Here's what I've got...

For recipes/rl-games:

• The summary item is expected in the about section.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rl-games) and found it was in an excellent condition.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rl-games) and found some lint.

Here's what I've got...

For recipes/rl-games:

• requirements: host: python<3.11 must contain a space between the name and the pin, i.e. python <3.11

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rl-games) and found it was in an excellent condition.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rl-games) and found some lint.

Here's what I've got...

For recipes/rl-games:

• noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rl-games) and found it was in an excellent condition.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rl-games) and found some lint.

Here's what I've got...

For recipes/rl-games:

• noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipes/rl-games:

• Please depend on pytorch directly, in order to avoid forcing CUDA users to downgrade to the CPU version for no reason.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rl-games) and found it was in an excellent condition.

[traversaro]

Thanks @flferretti for working on this! For the review it would be helpful to:

• explain why you need to set include_package_data to false?
• explain why you need to drop the use of poetry and delete the pyproject.toml, from https://github.com/conda-forge/dolo-feedstock/blob/ac4d17b604ed5fabdc40cac1bd6ecb982e714f73/recipe/meta.yaml#L12 it seems that you can use poetry also in conda-forge

[flferretti]

Thanks for review!

• explain why you need to set include_package_data to false?

I thought they were not useful for the recipe. This will install rl_games/configs/*.yaml, which I believe it to be not necessary in this case

• explain why you need to drop the use of poetry and delete the pyproject.toml, from https://github.com/conda-forge/dolo-feedstock/blob/ac4d17b604ed5fabdc40cac1bd6ecb982e714f73/recipe/meta.yaml#L12 it seems that you can use poetry also in conda-forge

This is interesting, I was not aware of this! The dependencies were recognized correctly by conda-forge at first, but the problem is that they are super strict and some packages are not currently available here, e.g. gym>=0.23, <0.24. For this reason, I decided to drop poetry and make conda solve the environment

[traversaro]

• explain why you need to drop the use of poetry and delete the pyproject.toml, from https://github.com/conda-forge/dolo-feedstock/blob/ac4d17b604ed5fabdc40cac1bd6ecb982e714f73/recipe/meta.yaml#L12 it seems that you can use poetry also in conda-forge

This is interesting, I was not aware of this! The dependencies were recognized correctly by conda-forge at first, but the problem is that they are super strict and some packages are not currently available here, e.g. gym>=0.23, <0.24. For this reason, I decided to drop poetry and make conda solve the environment

Perhaps we can use the --only-root option for handling this? See python-poetry/poetry#5783 .

[traversaro]

• explain why you need to drop the use of poetry and delete the pyproject.toml, from https://github.com/conda-forge/dolo-feedstock/blob/ac4d17b604ed5fabdc40cac1bd6ecb982e714f73/recipe/meta.yaml#L12 it seems that you can use poetry also in conda-forge

This is interesting, I was not aware of this! The dependencies were recognized correctly by conda-forge at first, but the problem is that they are super strict and some packages are not currently available here, e.g. gym>=0.23, <0.24. For this reason, I decided to drop poetry and make conda solve the environment

Perhaps we can use the --only-root option for handling this? See python-poetry/poetry#5783 .

Sorry, we aligned with @flferretti in person and the problem is a bit more complex. The problem here is that poetry/pyproject.toml and setup.py are basically inconsistent, i.e. they have a different set of dependencies and constraints. It seems that the one most recently updated is the setup.py, so indeed I think it make sense to just remove poetry/pyproject.toml and use setup.py.

[flferretti]

@conda-forge/help-python, @conda-forge/staged-recipes the recipe is now ready for review, thanks!

The Windows action is still failing because pytorch is not available.

[github-actions]

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

[traversaro]

I can confirm all my doubts have been addressed.