Add CUDA 11.8#25026
Merged
Merged
Conversation
Now that CUDA 11.8 is included in the global pinnings. Add it to staged-recipes to ensure it is tested as well.
jakirkham
force-pushed
the
add_cuda118
branch
from
17b61f4 to
fbe6d3a
Compare
Member
Author
|
Testing this change out with a recipe in PR ( #25027 ) |
Member
Author
|
@conda-forge/core , this is ready for review! |
h-vetinari
approved these changes
Jan 13, 2024
h-vetinari
left a comment
h-vetinari
left a comment
Member
There was a problem hiding this comment.
I wish we could template over the differences between 11.2 & 11.8 instead of fully duplicating things, but aside from that, LGTM
Member
Author
|
Agreed. Maybe CUDA 12 can be done in a better way since it can reuse the standard conda-forge Docker images |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that CUDA 11.8 is included in the global pinnings. Add it to staged-recipes to ensure it is tested as well.
xref: conda-forge/conda-forge-pinning-feedstock#5340