Skip to content

recipe for vllm#24710

Closed
mediocretech wants to merge 70 commits intoconda-forge:mainfrom
mediocretech:vllm
Closed

recipe for vllm#24710
mediocretech wants to merge 70 commits intoconda-forge:mainfrom
mediocretech:vllm

Conversation

@mediocretech
Copy link
Copy Markdown
Contributor

@mediocretech mediocretech commented Dec 7, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm) and found it was in an excellent condition.

@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm) and found some lint.

Here's what I've got...

For recipes/vllm:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm) and found it was in an excellent condition.

@mediocretech
Copy link
Copy Markdown
Contributor Author

Blocked by #24850

@iamthebot
Copy link
Copy Markdown
Contributor

iamthebot commented Feb 29, 2024

@mediocretech this isn't actually blocked. Please see this issue. tl;dr only the ninja package is actually needed there isn't a need for ninja-python. The Deepspeed conda package, as a result, does not do the pip check but the package works just fine.

Remove the pip check like deepspeed does.

Let me know if you'd like someone to take over this PR if you don't have bandwidth to make the changes. Would love to have this merged soon.

@mediocretech
Copy link
Copy Markdown
Contributor Author

mediocretech commented Mar 1, 2024 via email

@iamthebot
Copy link
Copy Markdown
Contributor

@mediocretech I think the build is failing due to crypt.h being missing which implies libxcrypt needs to be a "host" dependency.

Comment thread recipes/vllm/meta.yaml
Comment thread recipes/vllm/meta.yaml
Comment thread recipes/vllm/meta.yaml Outdated
@conda-forge-webservices
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm/meta.yaml) and found it was in an excellent condition.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@mediocretech
Copy link
Copy Markdown
Contributor Author

@iamthebot few more attempts made. Triton is looking blocked, see conda-forge/triton-feedstock#23

@iamthebot
Copy link
Copy Markdown
Contributor

@mediocretech basically the next steps for triton are listed here.

Unfortunately I'm pretty swamped for the rest of the quarter. I can probably come back to this late october.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Dec 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/vllm/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13990894647. Examine the logs at this URL for more detail.

@rongou
Copy link
Copy Markdown
Contributor

rongou commented Jan 15, 2025

Are you guys still working on this? Would love to see this getting over the finish line. Anything I can do to help?

@h-vetinari h-vetinari mentioned this pull request Jan 26, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants