Add recipe for labmaze #21512

traversaro · 2022-12-11T22:39:36Z

Checklist

conda-forge-linter · 2022-12-11T22:39:54Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/labmaze) and found it was in an excellent condition.

traversaro · 2022-12-13T20:20:49Z

The windows build fails with:

WARNING conda.gateways.disk.delete:unlink_or_rename_to_trash(140): Could not remove or rename C:\bld\labmaze_1670957684912\_build_env\Library\lib\jvm\lib\modules.  Please remove this file manually (you may need to reboot to free file handles)

Perhaps we need to stop the bazel daemon after starting it?

traversaro · 2022-12-17T11:28:53Z

Windows is failing with:

Using pip 22.3.1 from %PREFIX%\lib\site-packages\pip (python 3.9)
Non-user install because user site-packages disabled
Ignoring indexes: https://pypi.org/simple
Created temporary directory: C:\Users\VssAdministrator\AppData\Local\Temp\pip-build-tracker-zi5yv9ck
  File "C:\bld\labmaze_1670963390004\_h_env\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 231, in _prepare
    dist = self._prepare_distribution()
  File "C:\bld\labmaze_1670963390004\_h_env\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 308, in _prepare_distribution
    return preparer.prepare_linked_requirement(self._ireq, parallel_builds=True)
  File "C:\bld\labmaze_1670963390004\_h_env\lib\site-packages\pip\_internal\operations\prepare.py", line 491, in prepare_linked_requirement
    return self._prepare_linked_requirement(req, parallel_builds)
  File "C:\bld\labmaze_1670963390004\_h_env\lib\site-packages\pip\_internal\operations\prepare.py", line 577, in _prepare_linked_requirement
    dist = _get_prepared_distribution(
  File "C:\bld\labmaze_1670963390004\_h_env\lib\site-packages\pip\_internal\operations\prepare.py", line 69, in _get_prepared_distribution
    abstract_dist.prepare_distribution_metadata(
  File "C:\bld\labmaze_1670963390004\_h_env\lib\contextlib.py", line 126, in __exit__
    next(self.gen)
  File "C:\bld\labmaze_1670963390004\_h_env\lib\site-packages\pip\_internal\operations\build\build_tracker.py", line 124, in track
    self.remove(req)
  File "C:\bld\labmaze_1670963390004\_h_env\lib\site-packages\pip\_internal\operations\build\build_tracker.py", line 109, in remove
    os.unlink(self._entry_path(req.link))
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-build-tracker-zi5yv9ck\\a26f0086ae0a3a42b2df1119b19e6982d0cc6ba2b3c0a5678897774c'

macOS with:

    "_PyUnicode_AsEncodedString", referenced from:
        pybind11::detail::error_fetch_and_normalize::format_value_and_trace() const in _defaults.pic.o
    "_PyUnicode_AsUTF8AndSize", referenced from:
        pybind11::detail::string_caster<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, false>::load(pybind11::handle, bool) in _defaults.pic.o
    "_PyUnicode_AsUTF8String", referenced from:
        pybind11::str::operator std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >() const in _defaults.pic.o
    "_PyUnicode_FromString", referenced from:
        pybind11::detail::make_static_property_type() in _defaults.pic.o
        pybind11::detail::make_default_metaclass() in _defaults.pic.o
        pybind11::detail::make_object_base_type(_typeobject*) in _defaults.pic.o
        pybind11::str::str(char const*) in _defaults.pic.o
        pybind11::detail::dict_getitemstring(_object*, char const*) in _defaults.pic.o
    "_PyWeakref_NewRef", referenced from:
        pybind11::weakref::weakref(pybind11::handle, pybind11::handle) in _defaults.pic.o
    "_Py_GetVersion", referenced from:
        _PyInit__defaults in _defaults.pic.o
        pybind11::detail::type_caster<bool, void>& pybind11::detail::load_type<bool, void>(pybind11::detail::type_caster<bool, void>&, pybind11::handle const&) in _defaults.pic.o
  ld: symbol(s) not found for architecture x86_64
  clang-14: error: linker command failed with exit code 1 (use -v to see invocation)

macOS probably can be fixed either by passing -undefined dynamic_lookup or by linking the Python shared library (see bazelbuild/bazel#16413).

traversaro · 2022-12-17T15:34:49Z

macOS probably can be fixed either by passing -undefined dynamic_lookup or by linking the Python shared library (see bazelbuild/bazel#16413).

Directly linking the python libraries resulted in a segfault for some reason, let's switch to pass -undefined dynamic_lookup .

traversaro · 2022-12-17T19:13:31Z

The Windows problem was fixed by specifying to pip to use a temporary directory inside the working dir.

traversaro · 2022-12-17T19:14:30Z

@conda-forge/help-c-cpp the recipe is ready for review. As I am not expert in bazel I am not sure if I did everything fine from the bazel point of view, so this may be interesting also for @conda-forge/bazel .

carterbox · 2022-12-18T04:17:56Z

recipes/labmaze/meta.yaml

+{% set version = "1.0.6" %}
+
+package:
+  name: {{ name }}
+  version: {{ version }}
+
+source:
+  url: https://github.com/deepmind/labmaze/archive/6d7e8f058428025cd4253f1ef6a1ed6618d9b0ea.zip
+  sha256: dbd3e0b96e1b50936846bdc6f8f63d1199ca6319aefa64c0f5c9a5d29858f605


google-deepmind/labmaze#5

I updated the recipe to be more clear in 0c0c674 .

carterbox · 2022-12-18T04:22:13Z

recipes/labmaze/meta.yaml

+  host:
+    - pybind11
+    - pybind11-abi
+    - abseil-cpp


https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=630409&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823&l=5645

There's linking warnings about libabseil. Are you accidentally static linking?

This should be:

Suggested change

- abseil-cpp

- libabseil

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=630409&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823&l=5645

There's linking warnings about libabseil. Are you accidentally static linking?

I am using just an header-only part of abseil. I added an ignore of libabseil's run_exports in d85e453 to account for that.

h-vetinari · 2022-12-18T05:21:29Z

recipes/labmaze/unvendor_deps.patch

+    path = "/home/traversaro/mambaforge/envs/labmazedev/include",  # absl placeholder
+    build_file = "@//bazel:system_absl.BUILD"


How can this local path work in CI, or is this simply never built...?

This is replaced by setup.py, following the structure already used in the recipe for the python headers, however given that a random local path was confusing, I substituted it with a clearly fake path in 2a405c0 .

Co-authored-by: h-vetinari <[email protected]>

traversaro · 2022-12-22T09:50:40Z

@h-vetinari @carterbox thanks a lot for the comments, I tried to address them, once the review is completed I will stash the commits because ~35 are quite a lot.

traversaro added 7 commits December 11, 2022 21:15

Create meta.yaml

6ce016f

Update meta.yaml

f3b5722

Update meta.yaml

a7454a7

Create build.sh

bcc06ec

Update meta.yaml

131e21e

Update meta.yaml

3603eee

Create unvendor_deps.patch

6f76bb9

traversaro added 15 commits December 11, 2022 23:47

Update meta.yaml

f92225e

Update meta.yaml

d37956a

Update meta.yaml

b021e83

Update build.sh

96244ea

Update meta.yaml

37e716d

Update meta.yaml

977dfb0

Update unvendor_deps.patch

e8b73ea

Update meta.yaml

55b2472

Create bld.bat

1e81c01

Update build.sh

56d01c7

Update bld.bat

97ae0ba

Update meta.yaml

134fe61

Update meta.yaml

950c9a9

Update meta.yaml

e7217c2

Update bld.bat

c59d788

traversaro added 2 commits December 13, 2022 21:23

Update bld.bat

04d1bbb

Update build.sh

356fed3

traversaro added 3 commits December 17, 2022 15:03

Update unvendor_deps.patch

328afab

Update unvendor_deps.patch

17b3a54

Update unvendor_deps.patch

c2a7c36

Update bld.bat

5009b3c

traversaro added 3 commits December 17, 2022 16:39

Update unvendor_deps.patch

95ad90c

Update build.sh

90f9ad0

Update bld.bat

a090591

github-actions bot added c-cpp review-requested labels Dec 17, 2022

carterbox reviewed Dec 18, 2022

View reviewed changes

carterbox requested changes Dec 18, 2022

View reviewed changes

carterbox removed the review-requested label Dec 18, 2022

github-actions bot added the Awaiting author contribution label Dec 18, 2022

h-vetinari reviewed Dec 18, 2022

View reviewed changes

traversaro mentioned this pull request Dec 22, 2022

Shimmy conda-forge/gymnasium-feedstock#8

Open

traversaro and others added 4 commits December 22, 2022 10:41

Update unvendor_deps.patch

2a405c0

Update recipes/labmaze/meta.yaml

acf5d5f

Co-authored-by: h-vetinari <[email protected]>

Update meta.yaml

d85e453

Update meta.yaml

0c0c674

traversaro requested review from carterbox and h-vetinari and removed request for carterbox and h-vetinari December 22, 2022 10:57

Update unvendor_deps.patch

3667426

carterbox merged commit 8ca8df4 into conda-forge:main Dec 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recipe for labmaze #21512

Add recipe for labmaze #21512

traversaro commented Dec 11, 2022 •

edited

Loading

conda-forge-linter commented Dec 11, 2022

traversaro commented Dec 13, 2022

traversaro commented Dec 17, 2022

traversaro commented Dec 17, 2022

traversaro commented Dec 17, 2022

traversaro commented Dec 17, 2022

carterbox Dec 18, 2022

traversaro Dec 22, 2022

carterbox Dec 18, 2022

h-vetinari Dec 18, 2022

traversaro Dec 22, 2022

h-vetinari Dec 18, 2022

traversaro Dec 22, 2022 •

edited

Loading

traversaro commented Dec 22, 2022

		+ path = "/home/traversaro/mambaforge/envs/labmazedev/include", # absl placeholder
		+ build_file = "@//bazel:system_absl.BUILD"

Add recipe for labmaze #21512

Add recipe for labmaze #21512

Conversation

traversaro commented Dec 11, 2022 • edited Loading

conda-forge-linter commented Dec 11, 2022

traversaro commented Dec 13, 2022

traversaro commented Dec 17, 2022

traversaro commented Dec 17, 2022

traversaro commented Dec 17, 2022

traversaro commented Dec 17, 2022

carterbox Dec 18, 2022

Choose a reason for hiding this comment

traversaro Dec 22, 2022

Choose a reason for hiding this comment

carterbox Dec 18, 2022

Choose a reason for hiding this comment

h-vetinari Dec 18, 2022

Choose a reason for hiding this comment

traversaro Dec 22, 2022

Choose a reason for hiding this comment

h-vetinari Dec 18, 2022

Choose a reason for hiding this comment

traversaro Dec 22, 2022 • edited Loading

Choose a reason for hiding this comment

traversaro commented Dec 22, 2022

traversaro commented Dec 11, 2022 •

edited

Loading

traversaro Dec 22, 2022 •

edited

Loading