Add xerces-c #194

groutr · 2016-03-23T21:11:26Z

Split from #108

ocefpaf · 2016-03-23T21:15:42Z

recipes/xerces-c/build.sh

+--disable-network \
+--disable-static
+make
+make install


make check?

pelson · 2016-03-25T04:48:50Z

Win failure:

msbuild projects\Win32\VC9\xerces-all\xerces-all.sln /t:all /p:Configuration=Release;Platform=Win32 
Microsoft (R) Build Engine Version 2.0.50727.8007
[Microsoft .NET Framework, Version 2.0.50727.8009]
Copyright (C) Microsoft Corporation 2005. All rights reserved.

projects\Win32\VC9\xerces-all\xerces-all.sln(1): Solution file error MSB5014: File format version is not recognized.  MSBuild can only read solution files between versions 7.0 and 9.0, inclusive.

C:\Miniconda\conda-bld\work\xerces-c-3.1.3>if errorlevel 1 exit 1

Concerningly the linting hasn't propagated the error code on travis-ci (I'll dig into that), but in the meantime:

/Users/travis/build/conda-forge/staged-recipes/recipes/xerces-c has some lint:
  The recipe could do with some maintainers listed in the "extra/recipe-maintainers" section.
  The recipe must have some tests.

pelson · 2016-03-25T04:50:58Z

Also noticed that the Windows build x64 py35 is taking abnormally long and appears to be timing out:

jakirkham · 2016-03-26T00:13:09Z

recipes/xerces-c/meta.yaml

+  features:
+    - vc9    # [win and py27]
+    - vc10   # [win and py34]
+    - vc14   # [win and py35]


Do we need python as a build requirement then? Not sure how these work without it.

jakirkham · 2016-03-26T00:45:05Z

recipes/xerces-c/build.sh

+make
+make check
+make install
+


Drop extra newline.

I think in this case they provide the same source in 4 different types of archives.

jakirkham · 2016-03-26T02:18:20Z

recipes/xerces-c/meta.yaml

+  version: {{ version }}
+
+source:
+  url: http://mirrors.sonic.net/apache//xerces/c/3/sources/xerces-c-{{version}}.tar.gz


msarahan · 2016-03-26T02:27:41Z

recipes/xerces-c/bld.bat

+    set OUTDIR=Win32
+)
+
+if %PY3K% == 1 (


are there VC14 projects? If not, I recommend the upgrade path shown in https://github.com/conda/conda-build/wiki/Windows-recipe-patterns#updating-older-sln-files

Actually, just updating the VS2008 solution might be cleanest anyway.

conda-forge-admin · 2016-03-28T17:17:52Z

Hi! This is the friendly conda-forge-admin automated user.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/xerces-c) and found some lint.

Here's what I've got...

For recipes/xerces-c:

The recipe must have some tests.

ocefpaf · 2016-03-28T18:59:11Z

Also noticed that the Windows build x64 py35 is taking abnormally long and appears to be timing out:

That is still happening. Failing for
Environment: TARGET_ARCH=x86, CONDA_PY=27, PY_CONDITION=python >=2.7,<3
and stuck for
Environment: TARGET_ARCH=x64, CONDA_PY=35, PY_CONDITION=python >=3.5

groutr · 2016-03-28T19:59:24Z

@ocefpaf I'm not sure what is happening there.

groutr · 2016-03-30T17:21:41Z

Could the travis build be restarted?
https://ci.appveyor.com/project/conda-forge/staged-recipes/build/1.0.522/job/w605533g02ao9bp8 is very confusing for me.
I'm also kind of baffled with the error for Python 2.7. I get no msbuild errors when I use my copy of visual studio 2008.

jakirkham · 2016-03-30T17:22:51Z

The issue with Travis CI is a linting issue (not a build issue). The recipe needs some tests.

jakirkham · 2016-03-30T17:25:19Z

The Windows issue seems to be a complaint about the version of the .sln file provided. Though one of the jobs died or was canceled so will restart, but I expect that failure will return for that one case.

jakirkham · 2016-03-30T17:33:31Z

Windows restarted.

groutr · 2016-03-30T17:48:19Z

Can an updated msbuild be put on the build machines? Looks like you can compile your own from source (https://github.com/Microsoft/msbuild)

jakirkham · 2016-03-30T17:54:16Z

Interesting idea. I have seen that before. Honestly don't have a good enough Windows dev environment to engage in that project productively. Could we put that in an issue somewhere? Probably on the webpage repo. That way someone with more skill in this area and better tools can take a look at it.

ocefpaf · 2016-03-30T17:54:19Z

Can an updated msbuild be put on the build machines?

We can ask/request here. They are usually fast to respond.

patricksnape · 2016-03-30T18:52:34Z

I believe I've seen this problem before. It has to do with the Windows SDK 7 being installed after Visual Studio 2008 Express. For some reason Windows SDK 7 messes with something so that the vcvars32.bat doesn't correct set the @SET Framework35Version=v3.5 properly and so it reverts back to using msbuild v2.0 which is incorrect. You either need to make sure the msbuild from the .NET framework v3.5 is being used or you need to tell vcvars32.bat to @SET Framework35Version=v3.5.

ocefpaf · 2016-03-30T19:27:44Z

@groutr I cancelled AppVeyor due to #194 (comment)

We need to get the other packages out too 😉

jakirkham · 2016-03-30T19:30:08Z

Well, I believe there is another issue here. Namely, I think python needs to be a build requirement on Windows, which currently isn't the case with this recipe.

jakirkham · 2016-04-27T02:57:16Z

Restarted the CIs just to see how this would do. So much has happened in the last month. Some general issues (e.g. VS2008 64-bit support) referenced here are fixed. Might as well see what still remains.

Though there are still a few minor fixes required for this recipe before merging. It would be nice to complete them to get this into a good state and clear it.

jakirkham · 2016-05-24T03:20:40Z

Seem to be a lot of Windows failures. Does someone want to take a crack at it or can we just skip Windows and send it to a feedstock? This always can be addressed in the feedstock.

jakirkham · 2016-06-12T23:18:30Z

@gillins, I'm pinging you here so that you are aware of this PR to add xerces-c.

jakirkham · 2016-06-23T14:04:51Z

The work on this is continuing in PR ( #849 ).

msarahan · 2016-06-30T23:39:49Z

Closing, superseded by #849

JennPlothow

Duplicate of Added pylyzer as a package #22505

groutr added 2 commits March 23, 2016 16:10

add xerces-c

d7541e7

use jinja template for version

ac40f44

ocefpaf reviewed Mar 23, 2016
View reviewed changes

jakirkham reviewed Mar 26, 2016
View reviewed changes

groutr added 2 commits March 25, 2016 19:34

add make check

15b90cf

indent configure command options

dfd9262

jakirkham reviewed Mar 26, 2016
View reviewed changes

recipes/xerces-c/build.sh

make

make check

make install

Copy link

Member

jakirkham Mar 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop extra newline.

groutr added 2 commits March 25, 2016 20:04

add recipe maintainer

8467fb7

remove zip files

091d1ce

I think in this case they provide the same source in 4 different types of archives.

jakirkham reviewed Mar 26, 2016
View reviewed changes

jakirkham mentioned this pull request Mar 26, 2016

Collections of recipes needing attention? #161

Closed

msarahan reviewed Mar 26, 2016
View reviewed changes

build static libraries too

c636c33

jakirkham mentioned this pull request Apr 22, 2016

GDAL dependencies #108

Closed

jakirkham mentioned this pull request Jun 12, 2016

Use the toolchain conda-forge/hdf5-feedstock#22

Merged

gillins mentioned this pull request Jun 23, 2016

Add Xerces-c #849

Merged

msarahan closed this Jun 30, 2016

JennPlothow reviewed Apr 15, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add xerces-c #194

Add xerces-c #194

groutr commented Mar 23, 2016

ocefpaf Mar 23, 2016

pelson commented Mar 25, 2016

pelson commented Mar 25, 2016

jakirkham Mar 26, 2016

jakirkham Mar 26, 2016

jakirkham Mar 26, 2016

msarahan Mar 26, 2016

conda-forge-admin commented Mar 28, 2016

ocefpaf commented Mar 28, 2016

groutr commented Mar 28, 2016

groutr commented Mar 30, 2016

jakirkham commented Mar 30, 2016

jakirkham commented Mar 30, 2016

jakirkham commented Mar 30, 2016

groutr commented Mar 30, 2016

jakirkham commented Mar 30, 2016

ocefpaf commented Mar 30, 2016

patricksnape commented Mar 30, 2016

ocefpaf commented Mar 30, 2016

jakirkham commented Mar 30, 2016

jakirkham commented Apr 27, 2016

jakirkham commented May 24, 2016

jakirkham commented Jun 12, 2016

jakirkham commented Jun 23, 2016

msarahan commented Jun 30, 2016

JennPlothow left a comment

Add xerces-c #194

Add xerces-c #194

Conversation

groutr commented Mar 23, 2016

ocefpaf Mar 23, 2016

Choose a reason for hiding this comment

pelson commented Mar 25, 2016

pelson commented Mar 25, 2016

jakirkham Mar 26, 2016

Choose a reason for hiding this comment

jakirkham Mar 26, 2016

Choose a reason for hiding this comment

jakirkham Mar 26, 2016

Choose a reason for hiding this comment

msarahan Mar 26, 2016

Choose a reason for hiding this comment

conda-forge-admin commented Mar 28, 2016

ocefpaf commented Mar 28, 2016

groutr commented Mar 28, 2016

groutr commented Mar 30, 2016

jakirkham commented Mar 30, 2016

jakirkham commented Mar 30, 2016

jakirkham commented Mar 30, 2016

groutr commented Mar 30, 2016

jakirkham commented Mar 30, 2016

ocefpaf commented Mar 30, 2016

patricksnape commented Mar 30, 2016

ocefpaf commented Mar 30, 2016

jakirkham commented Mar 30, 2016

jakirkham commented Apr 27, 2016

jakirkham commented May 24, 2016

jakirkham commented Jun 12, 2016

jakirkham commented Jun 23, 2016

msarahan commented Jun 30, 2016

JennPlothow left a comment

Choose a reason for hiding this comment