Add libevent #1491
Add libevent #1491
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jakirkham
force-pushed
the
add_libevent
branch
from
8138d3c to
86e3374
Compare
jakirkham
force-pushed
the
add_libevent
branch
2 times, most recently
from
d0d5f10 to
5485a14
Compare
| ./autogen.sh | ||
| ./configure --prefix="${PREFIX}" | ||
| make | ||
| eval ${LIBRARY_SEARCH_VAR}="${PREFIX}/lib" make check |
There was a problem hiding this comment.
This test section is causing some sort of hanging behavior so it may need to be commented and skipped for now.
|
Cool. I don't have an immediate use for the non-blocking server in Apache Thrift, but it would be nice to get it building in conda-forge |
jakirkham
force-pushed
the
add_libevent
branch
from
5485a14 to
05dd677
Compare
| # | ||
| # Seems to hand on Mac builds. So have commented it for now. | ||
| # | ||
| #eval ${LIBRARY_SEARCH_VAR}="${PREFIX}/lib" make check |
There was a problem hiding this comment.
Will address this in the feedstock.
jakirkham
force-pushed
the
add_libevent
branch
2 times, most recently
from
bca4c6a to
e93afcc
Compare
jakirkham
force-pushed
the
add_libevent
branch
from
e93afcc to
d90c163
Compare
|
|
||
| run: | ||
| - openssl 1.0.* | ||
| - python |
There was a problem hiding this comment.
Didn't realize defaults had a copy of this package. Not seeing a recipe now that I'm looking. Though the defaults copy doesn't seem to depend on Python despite the fact there is a Python script installed.
There was a problem hiding this comment.
Opened issue ( ContinuumIO/anaconda-recipes#44 ) upstream about this problem.
|
Would love to get your thoughts on this, @msarahan. |
jakirkham
force-pushed
the
add_libevent
branch
from
d90c163 to
e5389c5
Compare
jakirkham
force-pushed
the
add_libevent
branch
from
7301548 to
eb14e55
Compare
|
After some discussion with Continuum, it seems the easiest path forward is to drop Python as dependency and remove the Python script that |
|
Thoughts on this recipe @ilanschnell ? |
|
@conda-forge/staged-recipes , could I please get a review of this PR and then PR ( #1507 )? |
| export LDFLAGS="-L${PREFIX}/lib ${LDFLAGS}" | ||
|
|
||
| # Set the fallback library environment variable. | ||
| if [[ `uname` == 'Darwin' ]]; |
There was a problem hiding this comment.
Isn't $(uname) preferred over backticks?
There was a problem hiding this comment.
Both work (albeit slightly differently). That being said, I don't have a preference. So went ahead and changed it.
|
LGTM @jakirkham other than the backtick thing |
[skip appveyor]
jakirkham
force-pushed
the
add_libevent
branch
from
b91d74b to
f650702
Compare
|
Thanks for the review @scopatz . Have incorporated your changes. |
|
Thanks! I'll merge after CI. |
|
Thanks @jakirkham! |
This adds a package for
libeventon OS X and Linux. It may be possible to get a Windows build once there is an official stable 2.1.x release.Letting you know as this may be of interest for
thrift-cpp, @wesm.