-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jxrlib from #6842 #10327
Add jxrlib from #6842 #10327
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/jxrlib/meta.yaml
Outdated
about: | ||
home: https://packages.debian.org/source/sid/jxrlib | ||
license: BSD-2-Clause | ||
summary: jxrlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest the summary
to be more descriptive since it appears in the channel info, something like:
summary: "jxrlib - JPEG XR Library by Microsoft, built from Debian hosted sources."
recipes/jxrlib/meta.yaml
Outdated
license_family: BSD | ||
license_file: LICENSE | ||
|
||
description: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the description
section all together, and maybe add a note that the package is no longer maintained by MS, e.g.:
extra:
notes: "This package seems to be no longer maintained by the original developer (Microsoft)."
@hmaarrfk , the recipe LGTM. If you don't mind modifying it according the comments, I can merge it afterwards. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/jxrlib:
|
thanks for the review. |
recipes/jxrlib/meta.yaml
Outdated
summary: "jxrlib - JPEG XR Library by Microsoft, built from Debian hosted sources." | ||
license_family: BSD | ||
license_file: LICENSE | ||
extra: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hmaarrfk , sorry for not being more clear earlier - notes goes under the extra section, where the recipe-maintainers are.
So, please remove extra
from here.
notes: "This package seems to be no longer maintained by the original developer (Microsoft)." | ||
|
||
extra: | ||
recipe-maintainers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add notes: "This package seems to be no longer maintained by the original developer (Microsoft)."
before or after the recipe-maintainers.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/jxrlib:
|
Thanks for the review again. are you ok with the linter failing? |
Ha, I use the I apologize for that - can you please remove the extra part completely, and add description as you had initially (just without the empty line)? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/jxrlib:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Many thanks for the patience and the prompt updates @hmaarrfk ! The recipe LGTM, so I will merge it once the tests pass. |
All good, happy to get this package along in conda-forge |
@hmaarrfk , I was not sure of the AppVeyor failure, but I was just told that as long as one win build passes, we are good, so I will go ahead and merge this PR. Thank you for the contribution! |
Thanks! |
@csachs i pulled this from your PR #6842 to try and move things along slowly :D
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)