Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jxrlib from #6842 #10327

Merged
merged 6 commits into from
Dec 13, 2019
Merged

Add jxrlib from #6842 #10327

merged 6 commits into from
Dec 13, 2019

Conversation

hmaarrfk
Copy link
Contributor

@csachs i pulled this from your PR #6842 to try and move things along slowly :D

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jxrlib) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title Add jrxlib from #6842 Add jxrlib from #6842 Nov 28, 2019
@hmaarrfk hmaarrfk mentioned this pull request Nov 29, 2019
16 tasks
about:
home: https://packages.debian.org/source/sid/jxrlib
license: BSD-2-Clause
summary: jxrlib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest the summary to be more descriptive since it appears in the channel info, something like:

summary: "jxrlib - JPEG XR Library by Microsoft, built from Debian hosted sources."

license_family: BSD
license_file: LICENSE

description: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the description section all together, and maybe add a note that the package is no longer maintained by MS, e.g.:

extra:
  notes: "This package seems to be no longer maintained by the original developer (Microsoft)."

@npavlovikj
Copy link
Contributor

@hmaarrfk , the recipe LGTM. If you don't mind modifying it according the comments, I can merge it afterwards.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/jxrlib) and found some lint.

Here's what I've got...

For recipes/jxrlib:

  • The about section contained an unexpected subsection name. extra is not a valid subsection name.

@hmaarrfk
Copy link
Contributor Author

thanks for the review.

summary: "jxrlib - JPEG XR Library by Microsoft, built from Debian hosted sources."
license_family: BSD
license_file: LICENSE
extra:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmaarrfk , sorry for not being more clear earlier - notes goes under the extra section, where the recipe-maintainers are.
So, please remove extra from here.

notes: "This package seems to be no longer maintained by the original developer (Microsoft)."

extra:
recipe-maintainers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add notes: "This package seems to be no longer maintained by the original developer (Microsoft)." before or after the recipe-maintainers.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/jxrlib) and found some lint.

Here's what I've got...

For recipes/jxrlib:

  • The extra section contained an unexpected subsection name. notes is not a valid subsection name.

@hmaarrfk
Copy link
Contributor Author

Thanks for the review again.

are you ok with the linter failing?

@npavlovikj
Copy link
Contributor

Ha, I use the notes section for bioconda recipes - I didn't know that it is bioconda-specific only.

I apologize for that - can you please remove the extra part completely, and add description as you had initially (just without the empty line)?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/jxrlib) and found some lint.

Here's what I've got...

For recipes/jxrlib:

  • The about section contained an unexpected subsection name. decription is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jxrlib) and found it was in an excellent condition.

@npavlovikj
Copy link
Contributor

Many thanks for the patience and the prompt updates @hmaarrfk ! The recipe LGTM, so I will merge it once the tests pass.

@hmaarrfk
Copy link
Contributor Author

All good, happy to get this package along in conda-forge

@npavlovikj
Copy link
Contributor

@hmaarrfk , I was not sure of the AppVeyor failure, but I was just told that as long as one win build passes, we are good, so I will go ahead and merge this PR.

Thank you for the contribution!

@npavlovikj npavlovikj merged commit 6da26b7 into conda-forge:master Dec 13, 2019
@hmaarrfk
Copy link
Contributor Author

Thanks!

@hmaarrfk hmaarrfk deleted the jxrlib branch December 13, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants