Skip to content

3.0.1#128

Closed
quasiben wants to merge 22 commits intoconda-forge:mainfrom
quasiben:3.0.1
Closed

3.0.1#128
quasiben wants to merge 22 commits intoconda-forge:mainfrom
quasiben:3.0.1

Conversation

@quasiben
Copy link
Member

@quasiben quasiben commented Mar 7, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@quasiben
Copy link
Member Author

quasiben commented Mar 7, 2023

Hmm, these are all failing with an assertion error during build:

    File "/home/conda/feedstock_root/build_artifacts/snowflake-connector-python_1678220708991/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/lib/python3.8/site-packages/setuptools/_distutils/command/build_ext.py", line 493, in _build_extensions_serial
      self.build_extension(ext)
    File "<string>", line 167, in build_extension
    File "<string>", line 202, in _get_arrow_lib_as_linker_input
  AssertionError
  error: subprocess-exited-with-error

@quasiben
Copy link
Member Author

quasiben commented Mar 9, 2023

Making progress but I'm still coming up short. Snowflake-connector is still trying to link against a particular version of libarrow_python. Note, I amended setup.py to look for libarrow_python in {PREFIX}/iib/python/site-packages/pyarrow as this is where the SO is installed now:

Failed to import ArrowResult. No Apache Arrow result set format can be used. ImportError: libarrow_python.so.1000: cannot open shared object file: No such file or directory
import: 'snowflake.connector.arrow_iterator'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/snowflake-connector-python_1678367109177/test_tmp/run_test.py", line 8, in <module>
    import snowflake.connector.arrow_iterator
ImportError: libarrow_python.so.1000: cannot open shared object file: No such file or directory

@hajapy
Copy link
Contributor

hajapy commented Mar 9, 2023

@quasiben have a look at the changes I was trying in #125

specifying the rpaths combined with some of your changes could possibly work 🤞

@quasiben
Copy link
Member Author

quasiben commented Mar 9, 2023

Thanks @hajapy giving that a try now!

@quasiben
Copy link
Member Author

quasiben commented Mar 9, 2023

This is mostly working but failing on some arm and windows builds

@quasiben
Copy link
Member Author

quasiben commented Mar 9, 2023

@hajapy @mariusvniekerk is it possible to re-run just those failing builds ?

@quasiben
Copy link
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/snowflake-connector-python-feedstock/actions/runs/4386386460.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [31, 32]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants