Skip to content

Rebuild for occt 7.9.0#98

Merged
adrianinsaval merged 3 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-occt790-0-1_hcc69a2
May 16, 2025
Merged

Rebuild for occt 7.9.0#98
adrianinsaval merged 3 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-occt790-0-1_hcc69a2

Conversation

@regro-cf-autotick-bot

Copy link
Copy Markdown
Contributor

This PR has been triggered in an effort to update occt790.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/15039041947 - please use this URL for debugging.

@conda-forge-admin

conda-forge-admin commented May 15, 2025

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15074683691. Examine the logs at this URL for more detail.

@oursland

Copy link
Copy Markdown
Contributor

The Windows build requires tbb_devel: 2022.

@adrianinsaval

Copy link
Copy Markdown
Contributor

yeah I wanted to get the conda-forge pin raised but it can't be done right now apparently conda-forge/conda-forge-pinning-feedstock#6635
I'll cherry pick your commit pinning tbb

@adrianinsaval

Copy link
Copy Markdown
Contributor

btw, I think tbb_devel is a missing dependency of vtk that we are working around by adding it to every package that needs vtk to build, probably it should be added as run dependency in vtk and removed from most downstream packages, that way we would not need to pin the version we need in every single feedstock. @conda-forge/vtk is this something we can fix in the vtk package for 9.3.1?

@adrianinsaval

Copy link
Copy Markdown
Contributor

this also begs the question why did occt pull in tbb 2022 in the first place?

@oursland

oursland commented May 16, 2025

Copy link
Copy Markdown
Contributor

I recall this. Previously tbb-devel was an inherited dependency of VTK. With VTK 9.3.1, this dependency was not present and occt failed to build. It is a dependency of occt, but previously not included because VTK brought it in. VTK 9.3.0 included tbb-devel, as does VTK 9.4.x, so the issue was due to the conda-forge pinning at 9.3.1 vtk>9.3.0.

@adrianinsaval

Copy link
Copy Markdown
Contributor

It is a dependency of occt

it should not be a direct dependency in the conda-forge builds:
https://github.com/conda-forge/occt-feedstock/blob/9a403e342bd211336671ed79a86fbcf9bae3e7f6/recipe/build.sh#L7
https://github.com/conda-forge/occt-feedstock/blob/9a403e342bd211336671ed79a86fbcf9bae3e7f6/recipe/bld.bat#L9

but vtk needs it to configure in cmake and doesn't list it as a dependency

@adrianinsaval

Copy link
Copy Markdown
Contributor

new occt build using tbb 2021 as it should will be available soon: conda-forge/occt-feedstock#123
I'll drop the tbb 2022 pin from this pr once it's available

@oursland

Copy link
Copy Markdown
Contributor

What I don't understand is that I let the tbb-devel defer to the upstream on occt-feedstock, which selected tbb-devel==2022, why is the pinning for tbb==2021?

@adrianinsaval

adrianinsaval commented May 16, 2025

Copy link
Copy Markdown
Contributor

I don't know why conda-smithy didn't add tbb_devel to the ci support yaml files simply rerendering today added it, @h-vetinari do you have any idea why occt 7.9 was built with tbb 2022 instead of the 2021 in conda-forge/occt-feedstock#118?

@adrianinsaval

Copy link
Copy Markdown
Contributor

why is the pinning for tbb==2021?

conda-forge/conda-forge-pinning-feedstock#6635 (review)

Unfortunately, tbb 2022 conflicts with our current MKL constraint (<2025), because mkl 2024 depends on tbb 2021.*

@adrianinsaval adrianinsaval force-pushed the rebuild-occt790-0-1_hcc69a2 branch from 8fd38bf to 03846ad Compare May 16, 2025 18:08
@adrianinsaval adrianinsaval merged commit 29898cc into conda-forge:main May 16, 2025
8 checks passed
@adrianinsaval adrianinsaval mentioned this pull request May 16, 2025
5 tasks
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-occt790-0-1_hcc69a2 branch May 16, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants