Meson on unix#231
Merged
Merged
Conversation
…nda-forge-pinning 2023.04.15.08.59.11
h-vetinari
requested review from
jakirkham,
msarahan,
ocefpaf and
rgommers
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
6 tasks
rgommers
approved these changes
Apr 17, 2023
rgommers
left a comment
rgommers
left a comment
Contributor
There was a problem hiding this comment.
This LGTM, thanks @h-vetinari!
I went through one native and one cross build log in detail, and the expected options are used, not much seems off. These are the only warnings that stood out:
WARNING:conda_build.build:The install/build script(s) for scipy deleted the following files (from dependencies) from the prefix:
['aarch64-conda-linux-gnu/lib/libquadmath.so*', 'aarch64-conda-linux-gnu/lib/libstdc++.so.6.0.29']
This will cause the post-link checks to mis-report. Please try not to delete and files (DSOs in particular) from the prefix
Warning: rpath /home/conda/feedstock_root/build_artifacts/scipy_1681714748500/_build_env/lib is outside prefix /home/conda/feedstock_root/build_artifacts/scipy_1681714748500/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place (removing it)
WARNING :: Failed to get_static_lib_exports(/home/conda/feedstock_root/build_artifacts/scipy_1681714748500/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/libtkstub8.6.a)
Unknown format
I think that's all harmless.
Member
Author
|
Thanks for the review! Yes, those warnings are irrelevant. Also got Isuru's OK for the rebase of his changes, merging. |
This was referenced Apr 23, 2023
|
Is there a reason the build number was not bumped in this PR? |
Member
Author
It was an oversight, sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up version of #205
Windows will have to wait for a capable fortran compiler that's not gfortran (flang hopefully...? LFortran? Ifort somehow in conda-forge?)
Closes #205