Skip to content

remove redundant version guard#154

Merged
ocefpaf merged 2 commits into
conda-forge:masterfrom
h-vetinari:master
Feb 5, 2021
Merged

remove redundant version guard#154
ocefpaf merged 2 commits into
conda-forge:masterfrom
h-vetinari:master

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

This has become obvious because the CI for #151 passed. Incidentally, also helpful because one of the aarch-builds timed out on master.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

The aarch timeouts are benign here, the material change was for ppc, which passed.

@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @conda-forge/scipy @isuruf

@rgommers rgommers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. and a == 1.5 check seems wrong anyway

@h-vetinari

Copy link
Copy Markdown
Member Author

@conda-forge/core
This is a dead-simple PR that's been approved for about 3 weeks - anyone feel like pressing the button? :)

@ocefpaf

ocefpaf commented Feb 2, 2021

Copy link
Copy Markdown
Member

@conda-forge/core
This is a dead-simple PR that's been approved for about 3 weeks - anyone feel like pressing the button? :)

Let us check what is going on with drone. I'm having trouble seeing the logs on mobile (away from the laptop at the moment).

@h-vetinari h-vetinari closed this Feb 2, 2021
@h-vetinari h-vetinari reopened this Feb 2, 2021
@h-vetinari

Copy link
Copy Markdown
Member Author

Let us check what is going on with drone.

It just timed out - probably just hit the slower one of the two machines.

@h-vetinari

Copy link
Copy Markdown
Member Author

Seems like it will have to be restarted manually though (not picking up the reopen)

@beckermr

beckermr commented Feb 2, 2021

Copy link
Copy Markdown
Member

Seems like it will have to be restarted manually though (not picking up the reopen)

use @conda-forge-admin restart ci

it closes then opens the pr and it bumps the drone API to restart the build

@h-vetinari

Copy link
Copy Markdown
Member Author

@conda-forge-admin, please restart ci

@h-vetinari

Copy link
Copy Markdown
Member Author

Restarting drone is a bit of a lottery. If the jobs land on the faster machine, they run through in <30min, if not, they time out. However, this build only changes some test requirements anyway, so it doesn't really matter if it fails.

@ocefpaf ocefpaf merged commit 7e154a3 into conda-forge:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants