scipy v1.5.0#129
Merged
rgommers merged 4 commits intoJun 27, 2020
Merged
Conversation
added 2 commits
June 21, 2020 18:02
…da-forge-pinning 2020.06.16.21.09.39
regro-cf-autotick-bot
requested review from
beckermr,
jakirkham,
msarahan,
ocefpaf and
rgommers
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Member
|
The pypy-only patch needs to be dropped, that's the only failure on non-ppcle that I can see. For ppcle however, there's a bunch of things going wrong: |
Member
|
@jayfurmanek, do you have any thoughts on the |
Contributor
|
SciPy now does have ppc64le CI as well, which is passing. So I'm guessing a difference in OpenBLAS version here that's the culprit. The SciPy CI uses OpenBLAS v0.3.9: https://github.com/scipy/scipy/blob/master/tools/openblas_support.py I'm not sure what's going on with the ppc64le special-casing ( |
Member
|
Glad to hear that! 😄 CI really helps. Good catch Ralf! Yeah we normally build against Netlib and then swap out the BLAS at runtime. Though I guess we are using Netlib for |
jakirkham
reviewed
Jun 23, 2020
| - mpmath | ||
| {% if ver_major_minor == "1.4" %} | ||
| {% if ver_major_minor == "1.5" %} | ||
| - blas * netlib # [ppc64le] | ||
| {% endif %} |
Member
There was a problem hiding this comment.
Would be good if someone could comment on whether we still need this or what it should be replaced with.
Member
|
Looks like it is passing. @conda-forge/scipy, can someone please double check our work? 🙂 |
Member
Contributor
|
Not sure about the answer to @jakirkham's pcc64le question, but this is all green and gh-130 also doesn't look like a blocker - any reason not to merge as is? |
Member
|
We can merge this, as the large majority of users will benefit, however, the failures that #130 exposes would still appear in the wild (as the respective combinations remain installable by users).
Aside from the ppc-errors, I see these as negligible. Note that this recipe is enforcing |
Contributor
They are likely present for 1.4.1 as well right, since the matrix testing in gh-130 wasn't done for 1.4.1? |
Contributor
|
Right now I see people installing SciPy wheels into conda envs, which is horribly broken right now, so let's merge this. |
Member
|
Sure, I'm all for timely merges for new versions of critical packages (I was in this PR about an hour after it opened 😉). The other issues are pre-existing as you say, and can be taken care of in follow-ups. |
Member
|
Thanks Ralf! Also thanks @h-vetinari for investigating things further. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:
Checklist before merging this PR:
license_fileis packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
NEW: If you want these PRs to be merged automatically, make an issue with
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever) and pip (pip install re-ver) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/25179, please use this URL for debugging