-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ray-packages v2.1.0 #78
ray-packages v2.1.0 #78
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
This will have to wait for #77. Once ready, we also need to unpin grpc completely. The previous problems were solved by ray-project/ray#28354, though upstream stayed conservative with a Edit: NVM, the cap was explicitly lifted in ray-project/ray@9505cd1 |
b0a4d8f
to
8185032
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/ray-packages-feedstock/actions/runs/3418176799. |
@mattip @vnlitvinov |
c853323
to
d919390
Compare
@vnlitvinov PTAL PS. I'd like to fix the OSX (see #80) before we merge this. |
d919390
to
53414c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the test failure is related to inability to start workers. Further up there is
ERROR services.py:1403 -- Failed to start the dashboard: \
Failed to start the dashboard, return code -11
Maybe there is something off elsewhere?
53414c7
to
c6e9b62
Compare
c6e9b62
to
a90557f
Compare
a90557f
to
1a3a316
Compare
In order to separate dashboard failures from other issues, could you add a test
before this line ray-packages-feedstock/recipe/meta.yaml Line 97 in 7002f2a
|
I tried to follow up an unlikely gut-feeling, and it seems indeed that a patch-version of protobuf might have broken things. In particular, things break with 4.21.9 but run through with 4.21.6 (in both cases with grpc 1.49.1) |
Nevermind, pinning protobuf seems to have backed the resolver into some weird corners. Let's try again even more explicitly. |
xref modin-project/modin#5208 also with Ray 2.1.0 (from pip, but other deps from conda-forge). |
OK, I wasn't thinking that the host-dep-at-build-time gets picked up as a lower bound, so grpcio 1.49.1 + protobuf 4.21.6 is impossible to co-install (grpc was built against libprotobuf 3.21.9, meaning it needs >=3.21.9 at runtime; this corresponds to protobuf 4.21.9 after protobuf's recent versioning scheme change) |
What would you think about extending the summary to mention all the different packages provided to make the summary at the various links like https://anaconda.org/conda-forge/ray-default more informative? I would like to link to it from https://docs.ray.io/en/latest/ray-overview/installation.html#installing-ray-with-anaconda as part of reworking that documentation stanza. - licenses/redis-hiredis-COPYING.txt
- licenses/tporadowski-redis-license.txt
- licenses/zlib-LICENSE.txt
- summary: Ray is a fast and simple framework for building and running distributed applications.
+ summary: |
+ Ray is a fast and simple framework for building and running distributed
+ applications. It is split into ray-core, ray-default, ray-dashboard,
+ ray-serve, ray-rllib, ray-k8s, ray-data, ray-tune, and ray-all packages.
description: |
Ray is a fast and simple framework for building and running
distributed applications.
|
Fine by me, though personally I'd extend the description rather than the summary (no strong preference however). |
…nda-forge-pinning 2022.11.15.10.48.28
Do we want to publish this with a pin for grpcio<1.49 for the moment? |
A pin sounds like the most practical solution indeed. |
CI is passing. I will merge tomorrow if there are no objections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, though I would like to mimic dependencies from setup.py
in a more close manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion left, can go without if you wish. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
automerged PR by conda-forge/automerge-action
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Closes: #76
Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3416647520, please use this URL for debugging.