Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerender and Update to 5.12.10 #189

Closed
wants to merge 15 commits into from
Closed

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Mar 21, 2021

TODO:

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

@Tobias-Fischer how did you get past the python=2 dependency?

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@Tobias-Fischer
Copy link
Contributor

Hi @hmaarrfk - I haven't touched the Python2 stuff; I left it as I found it (and it seems fine, doesn't it?).

@hmaarrfk
Copy link
Contributor Author

I guess the default channel removed the aarch package for python 2. Or maybe it was finding some other channel. I made a PR to fix this issue

@hmaarrfk
Copy link
Contributor Author

@conda-forge/qt this is ready for review.

@hmaarrfk
Copy link
Contributor Author

Honestly, I tried to build locally, and seem to have gotten an error on OSX. Admittedly, I'm on OSX BigSur which seems to have created havoc on open source projects.

I'm not sure if anybody can do a test build for OSX.

@hmaarrfk
Copy link
Contributor Author

I just got access to this OSX machine for a short time, so I'm not sure entirely how to use it.

@hmaarrfk
Copy link
Contributor Author

@conda-forge/core could somebody confirm that the OSX build is successful here? Qt 5.12.10 + this patch, or 5.12.11 (unreleased) is necessary to ensure compatibility with the latest OSX release.

@wolfv
Copy link
Member

wolfv commented Mar 27, 2021

@hmaarrfk I also tried to build qt with these patches here. Got some weird error when it tries to bootstrap ninja:

the symbol ___darwin_check_fd_set_overflow is missing.

_Undefined symbols for architecture x86_64:
  "___darwin_check_fd_set_overflow", referenced from:
      _RAND_poll in libcrypto.a(rand_unix.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)_

There are a lot of bug reports on that online (seems related to the SDK). I am now trying with 10.15 instead fo 10.12 ... or do you have another version of that SDK that works?

@hmaarrfk
Copy link
Contributor Author

i am folling the steps laid out in https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/276c13013f674fab262fc3e02bf2e90396334468/recipe/run_conda_forge_build_setup_osx#L12-L23 to prepare the build on my laptop. not sure if my computer went to sleep or if it is still going strong at 12 hours.

@hmaarrfk
Copy link
Contributor Author

It probably went to sleep

@sonelu
Copy link

sonelu commented Mar 27, 2021

@Tobias-Fischer sorry for joining it late in the party... How am I supposed to build the stuff? If I clone the PR and try to run python build-locally.py it tells me:

(ros1) Alex3-2:qt-feedstock Alex$ python build-locally.py 
valid configs are {'linux_aarch64_', 'win_64_', 'osx_64_', 'linux_64_'}
config not selected, please choose from the following:

1. linux_64_
2. linux_aarch64_
3. osx_64_
4. win_64_

> 3
selected osx_64_
Traceback (most recent call last):
  File "build-locally.py", line 75, in <module>
    main()
  File "build-locally.py", line 68, in main
    verify_config(ns)
  File "build-locally.py", line 50, in verify_config
    raise ValueError(
ValueError: only Linux configs currently supported, got osx_64_

Am I supposed to do it differently?

@wolfv
Copy link
Member

wolfv commented Mar 27, 2021

You can install conda-build and run "conda build . -m .ci-support/osx_64_.yml" and it's also necessary to download the 10.xx SDK from "phreaker". There are some docs regarding this in the conda-build docs.
However... I think for getting started with building conda recipes qt might not be the best place because it's a really, really long build.

@hmaarrfk
Copy link
Contributor Author

@wolfv i'm getting similar errors:

make[3]: Entering directory '$SRC_DIR/qtwebengine/src/buildtools'
( test -e Makefile.ninja || $SRC_DIR/qtbase/bin/qmake -o Makefile.ninja $SRC_DIR/qtwebengine/src/buildtools/ninja.pro ) && make -f Makefile.ninja 
make[3]: Entering directory '$SRC_DIR/qtwebengine/src/webengine/ui'
$SRC_DIR/qtbase/bin/qmake -install qinstall qmldir ../../../qml/QtWebEngine/Controls1Delegates/qmldir
make[3]: Entering directory '$SRC_DIR/qtwebengine/src/webengine/ui2'
$SRC_DIR/qtbase/bin/qmake -install qinstall qmldir ../../../qml/QtWebEngine/Controls2Delegates/qmldir
make[3]: Leaving directory '$SRC_DIR/qtwebengine/src/webengine/ui'
make[3]: Leaving directory '$SRC_DIR/qtwebengine/src/webengine/ui2'
Undefined symbols for architecture x86_64:
  "___darwin_check_fd_set_overflow", referenced from:
      SubprocessSet::DoWork() in libninja.a(subprocess-posix.o)
ld: symbol(s) not found for architecture x86_64
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

@isuruf
Copy link
Member

isuruf commented Apr 16, 2021

Use conda-smithy master, rerender and run build-locally.py. (Added this feature just for you)

@hmaarrfk
Copy link
Contributor Author

Your the best!

…v11, and conda-forge-pinning 2021.04.17.14.54.41
@hmaarrfk
Copy link
Contributor Author

Ok thanks. Using build-locally to restart a build. I also took care to tee the log to a file.

Should be done by EOD?

@hmaarrfk
Copy link
Contributor Author

  • Linux 64 builds started on personal server
  • Linux aarch builds started on conda-forge server.

@wolfv
Copy link
Member

wolfv commented Apr 21, 2021

do you guys also want an M1 build (with missing webengine?)

@hmaarrfk
Copy link
Contributor Author

@wolfv i thougth you were close to getting nss working.

Linux buils are failing with:

     - cannot install both readline-8.1-h46c0cb4_0 and readline-8.0-he28a2e2_2

@hmaarrfk
Copy link
Contributor Author

@wolfv
Copy link
Member

wolfv commented Apr 22, 2021

@hmaarrfk nss works (we got a build on conda-forge, even), but compiling webengine seems not easily doable (even with nss).

@hmaarrfk
Copy link
Contributor Author

@wolfv thanks for confirming this.

Ok lets go for it. Can you confirm that you compiled with the latest suggestions from isuruf?

@hmaarrfk
Copy link
Contributor Author

With the latest changes, I'm bulding things on linux and linux + aarch64

@hmaarrfk
Copy link
Contributor Author

Linux x64 build is uploaded to: https://anaconda.org/ramonaoptics/qt/files

aarch64 seems stuck even on the conda-forge server. Trying to build using qemu on my server.

@Tobias-Fischer
Copy link
Contributor

For aarch, try to set sth like "-j8" - I remember trying to use all cores almost always stalled the build.

@isuruf
Copy link
Member

isuruf commented Apr 23, 2021

I'm building pypy right now.

@isuruf
Copy link
Member

isuruf commented Apr 23, 2021

setting CPU_COUNT is the correct way. don't edit the recipe

@hmaarrfk
Copy link
Contributor Author

/home/hmaarrfk/mambaforge/conda-bld/linux-aarch64/qt-5.12.10-hedda21f_0.tar.bz2
export CPU_COUNT=2
conda build -m .ci_support/linux_aarch64_.yaml recipe/

works.

@Tobias-Fischer
Copy link
Contributor

So is this PR good to go now?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented May 2, 2021

Bulids for aarch, linux, and macosx have been upload to: https://anaconda.org/ramonaoptics/qt/files

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented May 8, 2021

what do we do about the windows build?

@hmaarrfk
Copy link
Contributor Author

@conda-forge/qt just bumping this up. I think we only had windows builds missing. Any idea what to do about those?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Oct 7, 2021

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk changed the title Update to 5.12.10 Rerender and Update to 5.12.10 Oct 7, 2021
@Tobias-Fischer
Copy link
Contributor

I guess we can close here @hmaarrfk?

@hmaarrfk
Copy link
Contributor Author

we should upgrade the version but I've made my peice

@hmaarrfk hmaarrfk closed this Jan 20, 2022
@binnurr
Copy link

binnurr commented May 13, 2022

Bulids for aarch, linux, and macosx have been upload to: https://anaconda.org/ramonaoptics/qt/files

How can I access these files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 5.12.10
8 participants