Skip to content

Refresh CUDA 12 migrator#64

Closed
conda-forge-admin wants to merge 3 commits into
conda-forge:mainfrom
conda-forge-admin:conda_forge_admin_63
Closed

Refresh CUDA 12 migrator#64
conda-forge-admin wants to merge 3 commits into
conda-forge:mainfrom
conda-forge-admin:conda_forge_admin_63

Conversation

@conda-forge-admin

@conda-forge-admin conda-forge-admin commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

Recently the CUDA 11.8 migrator was closed out ( conda-forge/conda-forge-pinning-feedstock#5340 ). As part of that it was determined a small updated was needed to the CUDA 12 migrator ( conda-forge/conda-forge-pinning-feedstock#5340 (comment) ). While this largely works for most feedstocks without changes, those that have use_local: true will have issues with re-rendering until the CUDA 12 migrator they have is updated. This PR pulls over those updates to fix re-rendering on the feedstock. Please let us know if you have any other questions.


Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #63.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #63

@conda-forge-webservices

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch_sparse-feedstock/actions/runs/7498724938.

@jakirkham

Copy link
Copy Markdown
Member

@conda-forge-admin , please re-render

@jakirkham jakirkham changed the title MNT: rerender Refresh CUDA 12 migrator Jan 12, 2024
@jakirkham

Copy link
Copy Markdown
Member

This is passing! 🎉

@conda-forge/pytorch_sparse this is ready for review 🙂

@h-vetinari

Copy link
Copy Markdown
Member

Same question as for nnpops. What's the point? We already have CUDA 12 here.

@jakirkham

Copy link
Copy Markdown
Member

Same answer. There's a description in the OP

@h-vetinari h-vetinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should just remove use_local: true, so that we automatically pick up changes from the pinning repo for this migration.

Also, please don't open PRs that pretend to be migrator-rebuilds if they're not. nevermind, the title is different enough, I still managed to get confused though...

@jakirkham

Copy link
Copy Markdown
Member

Going to keep the discussion in one thread: conda-forge/nnpops-feedstock#34 (comment)

We can summarize the conclusions here after

@jakirkham

Copy link
Copy Markdown
Member

Based on discussion with Axel in the other thread, this should be ok to move forward

Please let us know if you have any other questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@conda-forge-admin , please re-render

3 participants