Skip to content

Fixed cuda pinning for cuda and pytorch#70

Merged
Tobias-Fischer merged 3 commits into
conda-forge:mainfrom
das-intensity:cuda-fix
Mar 25, 2025
Merged

Fixed cuda pinning for cuda and pytorch#70
Tobias-Fischer merged 3 commits into
conda-forge:mainfrom
das-intensity:cuda-fix

Conversation

@das-intensity

@das-intensity das-intensity commented Mar 23, 2025

Copy link
Copy Markdown
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Similar to conda-forge/pytorch_sparse-feedstock#71 the pins for cuda weren't ensuring a consistent version of cuda, resulting in dependency inconsistencies.

Unlike that diff where I pinned cuda to existing cuda packages, I'm adding the cuda-version package with correct pinning to the host section.

@das-intensity

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin

conda-forge-admin commented Mar 23, 2025

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ top-level output has some malformed specs:
  • In section build: `pytorch ==cuda
  • In section host: `pytorch ==cuda
  • In section run_constrained: pytorch =*=cuda* Requirement spec fields should always be space-separated to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14070203899. Examine the logs at this URL for more detail.

@das-intensity das-intensity marked this pull request as draft March 23, 2025 22:30
@das-intensity

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@das-intensity das-intensity marked this pull request as ready for review March 23, 2025 23:27
Comment thread recipe/meta.yaml Outdated

@h-vetinari h-vetinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks! As I'm not a maintainer here, let's give @conda-forge/pytorch_scatter a few more days to respond, then I'm happy to merge.

@Tobias-Fischer Tobias-Fischer merged commit 26ee4bf into conda-forge:main Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants