Skip to content

WIP: Rebuild for pypy37 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy37.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1050673881, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. activate_in_script is not a valid subsection name.

For recipe:

  • It looks like the 'pytorch-cpu' output doesn't have any tests.

@hmaarrfk
Copy link
Contributor

It seems to fail because PyErr_WarnExplicit doesn't exist in PyPy

KumaTea/pytorch-aarch64#3

https://github.com/pytorch/pytorch/blob/master/torch/csrc/Exceptions.cpp#L209

@isuruf
Copy link
Member

isuruf commented Jul 21, 2021

cc @mattip

@hmaarrfk hmaarrfk changed the title Rebuild for pypy37 WIP: Rebuild for pypy37 Jul 21, 2021
@hmaarrfk
Copy link
Contributor

I think i patched it out, but i'm going to test just pypy non-cuda builds.

@hmaarrfk
Copy link
Contributor

    FAILED: caffe2/torch/CMakeFiles/torch_python.dir/csrc/jit/python/init.cpp.o
    /home/conda/feedstock_root/build_artifacts/pytorch-recipe_1626905758578/_build_env/bin/x86_64-conda-linux-gnu-c++ --sysroot=/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1626905758578/_build_env/x86_64-conda-linux-gnu/sysroot -DBUILDING_TESTS -DFMT_HEADER_ONLY=1 -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MMAP=1 -DHAVE_SHM_OPEN=1 -DHAVE_SHM_UNLINK=1 -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTHP_BUILD_MAIN_LIB -DTH_BLAS_MKL -DUSE_C10D -DUSE_C10D_GLOO -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DUSE_NUMPY -DUSE_RPC -DUSE_TENSORPIPE -DUSE_VALGRIND -D_FILE_OFFSET_BITS=64 -Dtorch_python_EXPORTS -I/tmp/pip-req-build-p_z9byin/build/aten/src -I/tmp/pip-req-build-p_z9byin/aten/src -I/tmp/pip-req-build-p_z9byin/build -I/tmp/pip-req-build-p_z9byin -I/tmp/pip-req-build-p_z9byin/cmake/../third_party/benchmark/include -I/tmp/pip-req-build-p_z9byin/build/caffe2/contrib/aten -I/tmp/pip-req-build-p_z9byin/third_party/onnx -I/tmp/pip-req-build-p_z9byin/build/third_party/onnx -I/tmp/pip-req-build-p_z9byin/third_party/foxi -I/tmp/pip-req-build-p_z9byin/build/third_party/foxi -I/tmp/pip-req-build-p_z9byin/torch/.. -I/tmp/pip-req-build-p_z9byin/torch/../aten/src -I/tmp/pip-req-build-p_z9byin/torch/../aten/src/TH -I/tmp/pip-req-build-p_z9byin/build/caffe2/aten/src -I/tmp/pip-req-build-p_z9byin/build/third_party -I/tmp/pip-req-build-p_z9byin/torch/../third_party/valgrind-headers -I/tmp/pip-req-build-p_z9byin/torch/../third_party/gloo -I/tmp/pip-req-build-p_z9byin/torch/../third_party/onnx -I/tmp/pip-req-build-p_z9byin/torch/csrc -I/tmp/pip-req-build-p_z9byin/torch/csrc/api/include -I/tmp/pip-req-build-p_z9byin/torch/lib -I/tmp/pip-req-build-p_z9byin/torch/lib/libshm -I/tmp/pip-req-build-p_z9byin/torch/csrc/api -I/tmp/pip-req-build-p_z9byin/c10/.. -I/tmp/pip-req-build-p_z9byin/torch/lib/libshm/../../../torch/lib -I/tmp/pip-req-build-p_z9byin/third_party/fmt/include -I/tmp/pip-req-build-p_z9byin/third_party/tensorpipe -I/tmp/pip-req-build-p_z9byin/build/third_party/tensorpipe -I/tmp/pip-req-build-p_z9byin/third_party/tensorpipe/third_party/libnop/include -I/tmp/pip-req-build-p_z9byin/torch/lib/c10d/.. -isystem /tmp/pip-req-build-p_z9byin/build/third_party/gloo -isystem /tmp/pip-req-build-p_z9byin/cmake/../third_party/gloo -isystem /tmp/pip-req-build-p_z9byin/cmake/../third_party/googletest/googlemock/include -isystem /tmp/pip-req-build-p_z9byin/cmake/../third_party/googletest/googletest/include -isystem /tmp/pip-req-build-p_z9byin/third_party/gemmlowp -isystem /tmp/pip-req-build-p_z9byin/third_party/neon2sse -isystem /tmp/pip-req-build-p_z9byin/third_party/XNNPACK/include -isystem /tmp/pip-req-build-p_z9byin/third_party -isystem /tmp/pip-req-build-p_z9byin/cmake/../third_party/eigen -isystem /home/conda/feedstock_root/build_artifacts/pytorch-recipe_1626905758578/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/site-packages/numpy/core/include -isystem /tmp/pip-req-build-p_z9byin/cmake/../third_party/pybind11/include -std=c++14 -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/conda/feedstock_root/build_artifacts/pytorch-recipe_1626905758578/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/include -fdebug-prefix-map=/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1626905758578/work=/usr/local/src/conda/pytorch-1.8.0 -fdebug-prefix-map=/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1626905758578/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh=/usr/local/src/conda-prefix -Wno-deprecated-declarations -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION -O3 -DNDEBUG -DNDEBUG -fPIC -DCAFFE2_USE_GLOO -DHAVE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD -fno-strict-aliasing -Wno-write-strings -Wno-strict-aliasing -pthread -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unknown-pragmas -std=gnu++14 -MD -MT caffe2/torch/CMakeFiles/torch_python.dir/csrc/jit/python/init.cpp.o -MF caffe2/torch/CMakeFiles/torch_python.dir/csrc/jit/python/init.cpp.o.d -o caffe2/torch/CMakeFiles/torch_python.dir/csrc/jit/python/init.cpp.o -c /tmp/pip-req-build-p_z9byin/torch/csrc/jit/python/init.cpp
    /tmp/pip-req-build-p_z9byin/torch/csrc/jit/python/init.cpp: In lambda function:
    /tmp/pip-req-build-p_z9byin/torch/csrc/jit/python/init.cpp:399:30: error: cannot bind non-const lvalue reference of type 'pybind11::detail::accessor<pybind11::detail::accessor_policies::sequence_item>&' to an rvalue of type 'pybind11::detail::generic_iterator<pybind11::detail::iterator_policies::sequence_slow_readwrite>::reference {aka pybind11::detail::accessor<pybind11::detail::accessor_policies::sequence_item>}'
                 for (auto& obj : inputs) {
                                  ^~~~~~
    /tmp/pip-req-build-p_z9byin/torch/csrc/jit/python/init.cpp: In lambda function:
    /tmp/pip-req-build-p_z9byin/torch/csrc/jit/python/init.cpp:420:30: error: cannot bind non-const lvalue reference of type 'pybind11::detail::accessor<pybind11::detail::accessor_policies::sequence_item>&' to an rvalue of type 'pybind11::detail::generic_iterator<pybind11::detail::iterator_policies::sequence_slow_readwrite>::reference {aka pybind11::detail::accessor<pybind11::detail::accessor_policies::sequence_item>}'
                 for (auto& obj : inputs) {
                                  ^~~~~~
    [4616/4705] Building CXX object caffe2/torch/CMakeFiles/torch_python.dir/csrc/jit/passes/onnx/cast_all_constant_to_floating.cpp.o

@mattip
Copy link

mattip commented Jul 22, 2021

Thanks for pinging me. I opened an issue for PyWarnings* which as of yet does not exist in PyPy

+ for (const auto& obj : inputs) {
stack.push_back(toTypeInferredIValue(obj));
}
ArgumentSpec spec = arg_spec_creator.create(with_grad, stack);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there is another one on line 420. How does this work on CPython?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly, i don't know. i fixed one so it would verify my hypothesis that this was the cause

@hmaarrfk
Copy link
Contributor

There seems to be a few more const qualifies missing in a different file, as well as other debugging functions that are not implemented in PhPy

@hmaarrfk
Copy link
Contributor

@mattip any way you can take a look, seems like compilation finished, but import failed with:

import: 'torch'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/test_tmp/run_test.py", line 2, in <module>
    import torch
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/__init__.py", line 561, in <module>
    from .functional import *
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/functional.py", line 6, in <module>
    import torch.nn.functional as F
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/nn/__init__.py", line 1, in <module>
    from .modules import *
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/nn/modules/__init__.py", line 2, in <module>
    from .linear import Identity, Linear, Bilinear, LazyLinear
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/nn/modules/linear.py", line 6, in <module>
    from .. import functional as F
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/nn/functional.py", line 11, in <module>
    from .._jit_internal import boolean_dispatch, _overload
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/_jit_internal.py", line 20, in <module>
    import torch.distributed.rpc
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/distributed/rpc/__init__.py", line 24, in <module>
    from . import api, backend_registry, functions
  File "/home/conda/feedstock_root/build_artifacts/pytorch-recipe_1627072971526/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/site-packages/torch/distributed/rpc/api.py", line 443, in <module>
    assert docstring is not None, "RRef user-facing methods should all have docstrings."

@benjaminrwilson
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@benjaminrwilson
Copy link
Contributor

@conda-forge-admin, please rerun bot

@conda-forge-linter conda-forge-linter added the bot-rerun Instruct the bot to retry the PR label Aug 1, 2021
@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/1087990903

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-pypy37-0-1_h018784 branch August 1, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants