#328 + remove TH_BINARY_BUILD#331
Conversation
…nda-forge-pinning 2025.01.20.14.49.21
a successful copy operation may either turn 1, 3, 5 or 7, see https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/robocopy#exit-return-codes and given how atrocious boolean comparisions are in batch (no && or ||, much less set inclusions), just avoid it; c.f. also https://superuser.com/a/280434
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Include Python in build env also when building natively. Otherwise, we end up with Python 3.13 in build env and Python files are byte-compiled for both target Python and 3.13.
This reverts commit 3ebf1a9.
…nda-forge-pinning 2025.01.23.20.59.37
This reverts commit fc5693c.
This patch was only needed because of `TH_BINARY_BUILD`.
…nda-forge-pinning 2025.01.24.17.08.54
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12962634810. Examine the logs at this URL for more detail. |
h-vetinari
left a comment
There was a problem hiding this comment.
Glad that you now can trigger jobs yourself! 🥳
| # conda-specific patch, upstream force-disables libcufile w/ TH_BINARY_BUILD | ||
| # for their PyPI wheel builds | ||
| - patches/0008-Allow-libcufile-for-conda-builds.patch |
There was a problem hiding this comment.
For a simple removal, regenerating the patches isn't strictly necessary - it'll happen soon enough again anyway (i.e. with the next version). No change necessary, just noting that for future reference.
|
Thanks! |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Same as #328, plus remove
TH_BINARY_BUILDto see if CI passes.