Pytorch 2.4.1, python 3.13, cudnn9 by regro-cf-autotick-bot · Pull Request #261 · conda-forge/pytorch-cpu-feedstock

regro-cf-autotick-bot · 2024-09-19T10:45:51Z

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.}

Also includes...

Fixes #264
Fixes #259

conda-forge-webservices · 2024-09-19T10:46:00Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk · 2024-09-20T15:24:17Z

~~if anybody could rebuild OSX that would be great!~~

Edit: nevermind, i forgot about
#256 and #259

hmaarrfk · 2024-09-21T18:02:05Z

cudnn 9 would make this package incompatible with cupy.
conda-forge/cupy-feedstock#286

Would it be appropriate to build out 2 versions, one for cudnn 9, the other for cudnn 8???

conda-forge-webservices · 2024-09-22T19:34:00Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

If python is a host requirement, it should be a run requirement.

conda-forge-webservices · 2024-09-22T19:55:52Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk · 2024-09-22T21:06:56Z

I thought that it i could get things to work by downgrading to 2.4.0 instead of 2.4.1.... but it still doesn't work

Tobias-Fischer · 2024-09-22T21:40:38Z

It looks like it's going ok so far? :)

hmaarrfk · 2024-09-22T21:44:26Z

No I ran it locally in docker on a linux-64 host and ran into the same problem as
#256

hmaarrfk · 2024-10-05T00:30:12Z

you are welcome to try, i can back off.

hmaarrfk · 2024-10-05T00:31:17Z

actuallly my guess is that cmake is invoked through a new codepath i didn't capture in my patch.

jakirkham · 2024-10-05T00:53:33Z

I trust your judgment Mark. Please let me know if I'm just missing things

Edit: Fixed a typo

hmaarrfk · 2024-10-05T00:54:19Z

I’m too tired for today. Just giving ideas.

…nda-forge-pinning 2024.10.04.13.32.50

hmaarrfk · 2024-10-05T16:50:45Z

I think it is a difference between numpy 2.0 and 2.1.

Is there a reason to to build with 2.0 vs 2.1?

The reason i ask is that the migration pins to 2.0:
https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/numpy2.yaml#L48

…nda-forge-pinning 2024.10.04.13.32.50

h-vetinari · 2024-10-05T17:16:04Z

Is there a reason to to build with 2.0 vs 2.1?

Just because we started out conservatively. You can use 2.1 without issue, or pin to 2 directly

hmaarrfk · 2024-10-05T17:30:15Z

i'm not so convinced about my 2.1 theory anymore. I had successful builds with Linux64 and aarch64 in the past...

hmaarrfk · 2024-10-06T00:24:08Z

@isuruf it seems the sed “fix” was at the source of the issue. Any other ideas on how to make sed better? Or should we just restart builds periodically.

…nda-forge-pinning 2024.10.04.13.32.50

hmaarrfk · 2024-10-06T16:29:13Z

Well thank you all!!!!!

jakirkham · 2024-10-07T18:49:49Z

Hooray! 🥳

Thanks everyone! 🙏

This should help in the case of cross compilation. xref: conda-forge/pytorch-cpu-feedstock#261

…ization script (#137331) This should help in the case of cross compilation. xref: conda-forge/pytorch-cpu-feedstock#261 Fixes #ISSUE_NUMBER Pull Request resolved: #137331 Approved by: https://github.com/isuruf, https://github.com/seemethere

…ization script (pytorch#137331) This should help in the case of cross compilation. xref: conda-forge/pytorch-cpu-feedstock#261 Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#137331 Approved by: https://github.com/isuruf, https://github.com/seemethere

regro-cf-autotick-bot requested review from Tobias-Fischer, beckermr, benjaminrwilson, hmaarrfk and sodre as code owners September 19, 2024 10:45

hmaarrfk mentioned this pull request Sep 19, 2024

Update to Pytorch 2.4.1 #263

Closed

1 task

hmaarrfk changed the title ~~Rebuild for python 3.13~~ Rebuild for python 3.13 and cudnn 9 Sep 21, 2024

hmaarrfk force-pushed the rebuild-python313-0-1_h3e3c58 branch 2 times, most recently from 47a96d9 to 2665bfd Compare September 22, 2024 18:40

hmaarrfk changed the title ~~Rebuild for python 3.13 and cudnn 9~~ Rebuild for python 3.13 Sep 22, 2024

regro-cf-autotick-bot and others added 2 commits October 2, 2024 07:38

Rebuild for python 3.13

4b97487

Update to 2.4.1

054fb31

hmaarrfk force-pushed the rebuild-python313-0-1_h3e3c58 branch from 0ffc036 to 4f14b13 Compare October 2, 2024 12:14

hmaarrfk changed the title ~~Rebuild for python 3.13~~ Pytorch 2.4.1, python 3.13, cudnn9 Oct 2, 2024

hmaarrfk added 5 commits October 2, 2024 08:18

unskip "not aarch64"

7853499

Simplify cmake

9efae8f

Do not make changes to ci setup

9bafcc9

Add cudnn9

3ba0051

Bump the aarch docker image

5b836af

hmaarrfk force-pushed the rebuild-python313-0-1_h3e3c58 branch from 7b062b5 to da0e9fd Compare October 2, 2024 12:18

h-vetinari force-pushed the rebuild-python313-0-1_h3e3c58 branch from da0e9fd to be0a19c Compare October 2, 2024 13:10

fix image override on aarch

dc24bde

hmaarrfk added 3 commits October 4, 2024 21:24

Simplify build.sh

f56b78e

Go back to old ci setup

5e677dc

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.41.1, and co…

0a64808

…nda-forge-pinning 2024.10.04.13.32.50

hmaarrfk added 3 commits October 5, 2024 12:58

undor remote ci setup

16ef3a7

Skip so much stuff

68e55f2

MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.41.1, and co…

57015bd

…nda-forge-pinning 2024.10.04.13.32.50

Disable one of hte 2 patches

4814113

hmaarrfk removed the automerge Merge the PR when CI passes label Oct 5, 2024

Undo sed "fix"

fd011ec

hmaarrfk added 4 commits October 5, 2024 20:39

do one more replacement

b6e2d2e

one more replacement for good measure

5c6f02f

Unskip stuffs

77da201

MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.41.1, and co…

1ac3036

…nda-forge-pinning 2024.10.04.13.32.50

hmaarrfk added the automerge Merge the PR when CI passes label Oct 6, 2024

hmaarrfk merged commit 31fdb5f into conda-forge:main Oct 6, 2024

regro-cf-autotick-bot deleted the rebuild-python313-0-1_h3e3c58 branch October 6, 2024 16:36

hmaarrfk mentioned this pull request Oct 8, 2024

Help-Wanted Priority List #273

Closed

pytorch-bot Bot pushed a commit to pytorch/pytorch that referenced this pull request Nov 26, 2024

Allow users to overwrite ld with environment variables

f926884

This should help in the case of cross compilation. xref: conda-forge/pytorch-cpu-feedstock#261

Uh oh!

Uh oh!

Conversation

regro-cf-autotick-bot commented Sep 19, 2024 • edited by jakirkham Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-webservices Bot commented Sep 19, 2024

Uh oh!

hmaarrfk commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hmaarrfk commented Sep 21, 2024

Uh oh!

conda-forge-webservices Bot commented Sep 22, 2024

Uh oh!

conda-forge-webservices Bot commented Sep 22, 2024 • edited by conda-forge-admin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hmaarrfk commented Sep 22, 2024

Uh oh!

Tobias-Fischer commented Sep 22, 2024

Uh oh!

hmaarrfk commented Sep 22, 2024

Uh oh!

hmaarrfk commented Oct 5, 2024

Uh oh!

hmaarrfk commented Oct 5, 2024

Uh oh!

jakirkham commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hmaarrfk commented Oct 5, 2024

Uh oh!

hmaarrfk commented Oct 5, 2024

Uh oh!

h-vetinari commented Oct 5, 2024

Uh oh!

hmaarrfk commented Oct 5, 2024

Uh oh!

hmaarrfk commented Oct 6, 2024

Uh oh!

hmaarrfk commented Oct 6, 2024

Uh oh!

jakirkham commented Oct 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

regro-cf-autotick-bot commented Sep 19, 2024 •

edited by jakirkham

Loading

hmaarrfk commented Sep 20, 2024 •

edited

Loading

conda-forge-webservices Bot commented Sep 22, 2024 •

edited by conda-forge-admin

Loading

jakirkham commented Oct 5, 2024 •

edited

Loading