Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental] rattler #179

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

moritzwilksch
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • The top level meta key schema_version is unexpected
  • There are 1 too many lines. There should be one empty line at the end of the file.

For recipe/recipe.yaml:

  • No valid build backend found for Python recipe for package pyright using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@moritzwilksch
Copy link
Member Author

@wolfv it seems like

  1. rattler is invoked without the -m variant flag here (linux_64 build)
  2. in the linux_aarch64 the target platform looks sus 👀

@wolfv
Copy link
Member

wolfv commented Sep 26, 2024

yep, this is basically the issue I am trying to fix here: conda-forge/conda-forge-ci-setup-feedstock#353

The linux-aarch64 thing might be another problem that we need to correct (rattler-build not reading the target platform from a variant file).

@moritzwilksch
Copy link
Member Author

@conda-forge-admin, please restart ci

Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@moritzwilksch
Copy link
Member Author

@wolfv do the changes in conda-forge-ci-setup-feedstock deploy from main or how can I try whether this fixed the issue here?

@wolfv
Copy link
Member

wolfv commented Sep 30, 2024

Right now you seem to have a conflict with meta.yaml. If you re-render things should theoretically work (if there are no other rattler-build specific issues!) :)

Copy link
Contributor

github-actions bot commented Sep 30, 2024

        Hi! This is the friendly automated conda-forge-linting service.

        I wanted to let you know that I linted all conda-recipes in your             PR (```recipe/recipe.yaml```) and found some lint.

        Here's what I've got...

For recipe/recipe.yaml:

  • The top level meta key schema_version is unexpected
  • There are 1 too many lines. There should be one empty line at the end of the file.

For recipe/recipe.yaml:

  • No valid build backend found for Python recipe for package pyright using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@moritzwilksch
Copy link
Member Author

thank you that fixed the original problem! Target platform detection also seems to work but now there's a new error for aarch64 and ppc64le:

FileNotFoundError: [Errno 2] No such file or directory: '/home/conda/feedstock_root/build_artifacts/linux-aarch64'

@wolfv
Copy link
Member

wolfv commented Sep 30, 2024

I think the problem is that we need to fix conda-smithy for cross-compilation with rattler-build. The target platform needs to be passed explicitly on the command line (not as part of the variant config). I'll try to get to it tomorrow :)

@moritzwilksch
Copy link
Member Author

amazing! As always, rattler-build is a joy to use, thank you so much for building it 🙃😍

…5adcc7f8, and conda-forge-pinning 2024.09.30.02.36.09
@wolfv
Copy link
Member

wolfv commented Sep 30, 2024

Pushed rerender with a development version of conda-smithy to check wether things migth be fixed :)

@wolfv
Copy link
Member

wolfv commented Sep 30, 2024

Alright, now we're hitting different issues! 🚀
I need to figure out what to do with the __osx package on osx-arm64 :)

@moritzwilksch
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants