Skip to content

Update to 7.3.11; remove duplicated CI jobs#24

Merged
mattip merged 8 commits into
conda-forge:mainfrom
h-vetinari:ci
Feb 1, 2023
Merged

Update to 7.3.11; remove duplicated CI jobs#24
mattip merged 8 commits into
conda-forge:mainfrom
h-vetinari:ci

Conversation

@h-vetinari

@h-vetinari h-vetinari commented Apr 10, 2022

Copy link
Copy Markdown
Member

I saw in #23 that each pypy version gets built 3 times (once per cpython version). I don't quite see where the rerender picks up a supposedly unpinned - python in meta.yaml, but the following cbc-hack would do the trick. Not saying it's pretty, just a proposal.

Edit: now that conda-forge/pypy3.6-feedstock#99 has landed, update the version here.

Closes #26

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @conda-forge/pypy-meta :)

@conda-forge-webservices

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Updated to take into account #26

@h-vetinari h-vetinari changed the title Remove duplicated CI jobs Update to 7.3.11; remove duplicated CI jobs Jan 30, 2023
Comment thread recipe/conda_build_config.yaml Outdated
@mattip

mattip commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Close/reopen to rerun the travis builds

@mattip mattip closed this Feb 1, 2023
@mattip mattip reopened this Feb 1, 2023
@h-vetinari h-vetinari closed this Feb 1, 2023
@h-vetinari h-vetinari reopened this Feb 1, 2023
@h-vetinari

Copy link
Copy Markdown
Member Author

@conda-forge-admin, please restart ci

@h-vetinari

Copy link
Copy Markdown
Member Author

Travis is not picking up the restarts. As a feedstock maintainer, you should be able to trigger a rerun in the GH UI under the "Checks" tab.

@h-vetinari

Copy link
Copy Markdown
Member Author

Ah, wait, just saw the following banner on travis:

Builds have been temporarily disabled for public repositories due to a negative credit balance. Please go to the Plan page to replenish your credit balance or alter your Consume paid credits for OSS setting.

@h-vetinari

Copy link
Copy Markdown
Member Author

So travis is out of credits, but things seem to work fine in emulation. PTAL @conda-forge/pypy-meta, would be great to have the new pypy releases for work in scipy/grpc/arrow etc... :)

@mattip mattip merged commit 2c30014 into conda-forge:main Feb 1, 2023
@mattip

mattip commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @h-vetinari

@h-vetinari h-vetinari deleted the ci branch February 1, 2023 11:02
@h-vetinari

Copy link
Copy Markdown
Member Author

OK, this is now causing some unexpected side-effects. Due to pypy having a newer python "version" (referring to the stdlib portion here) than we have in CPython, this now will update random 3.9 environments from CPython to PyPy:

The following packages will be UPDATED:

  python                          3.9.15-h4de0772_0_cpython --> 3.9.16-0_73_pypy

IMO, using PyPy should remain opt-in, and we shouldn't switch the python implementation under the feet of users. So perhaps we might need to mark those builds as broken for now?

CC @conda-forge/core

@mattip

mattip commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

oy. Is there a way to prevent this?

@mattip

mattip commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

CI passes after rerendering the 3.8.16 PR

@mattip

mattip commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

It seems there will be cpython 3.9.16 very soon, and cpython 3.8.16 was recently made available. Going forward, can we add a test to the build here that will prevent this? Something like conda search and make sure the proper cpython build exists?

@jakirkham

jakirkham commented Feb 1, 2023

Copy link
Copy Markdown
Member

Yeah we should do something better here. Testing or avoiding this issue altogether. Raised issue ( #27 ). Please feel free to add more there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to PyPy 3.8.16, PyPy 3.9.16

4 participants