-
-
Notifications
You must be signed in to change notification settings - Fork 28
Rebuild for python 3.14 #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…04.02.19.31 Other tools: - conda-build 25.7.0 - rattler-build 0.46.0 - rattler-build-conda-compat 1.4.5
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18185256803. Examine the logs at this URL for more detail. |
|
Let's wait for pandas at least |
|
Python 3.14 is releasing in two (!) weeks. Is Pandas blocking? |
Pandas has an optional dependency with an uncapped constraint on pyarrow. I want this interaction tested in advance.
Aside from the fact that this is simply a reality due to the situation with pandas, the correct frame of reference is IMO that we're already months faster than the old days of starting to migrate (and make packages compatible) after If anyone has an expectation that everything will (or should) be ready when python Footnotes
|
|
@conda-forge-admin, please rerender Let's see if this works after conda-forge/pandas-feedstock#233 is merged. |
|
Interesting, Python 3.14 tests run fine on CUDA-enabled builds, but fail on non-CUDA builds. E.g. at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1355697&view=logs&j=bc49ae96-d8c4-56c3-76c1-860716735ea0&t=0253630d-55a2-5a8f-6f1e-0f6dde5e58c0&l=7641, there is this one test failure: ___________________________ test_to_pandas_zero_copy ___________________________
@pytest.mark.pandas
def test_to_pandas_zero_copy():
import gc
arr = pa.array(range(10))
for i in range(10):
series = arr.to_pandas()
> assert sys.getrefcount(series) == 2
E assert 1 == 2
E + where 1 = <built-in function getrefcount>(0 0\n1 1\n2 2\n3 3\n4 4\n5 5\n6 6\n7 7\n8 8\n9 9\ndtype: int64)
E + where <built-in function getrefcount> = sys.getrefcount
pyarrow/tests/test_array.py:295: AssertionErrorI see at apache/arrow@f58ba4c (in apache/arrow#47616) that a refcount of 1 or 2 should be valid (makes sense since this should be zero copy). Maybe apply that commit as a patch? |
That's because we don't run the tests for the CUDA builds, because we only build/publish them once. pyarrow-feedstock/recipe/meta.yaml Lines 214 to 219 in 1e54db0
|
Co-authored-by: Wei Ji <[email protected]>
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
…47616) ### Rationale for this change Python 3.14 is currently in a prerelease status and is expected to have a final release in October this year (https://peps.python.org/pep-0745/). We should ensure we are fully ready to support Python 3.14 for the PyArrow 22 release. ### What changes are included in this PR? This PR updates wheels for Python 3.14. ### Are these changes tested? Tested in the CI and with extended builds. ### Are there any user-facing changes? No, but users will be able to use PyArrow with Python 3.14. * GitHub Issue: #47438 --- Todo: - Update the image revision name in `.env` - Add 3.14 conda build ([arrow/dev/tasks/tasks.yml](https://github.com/apache/arrow/blob/d803afcc43f5d132506318fd9e162d33b2c3d4cd/dev/tasks/tasks.yml#L809)) when conda-forge/pyarrow-feedstock#156 is merged Follow-ups: - #47437 Authored-by: AlenkaF <[email protected]> Signed-off-by: AlenkaF <[email protected]>
…47616) ### Rationale for this change Python 3.14 is currently in a prerelease status and is expected to have a final release in October this year (https://peps.python.org/pep-0745/). We should ensure we are fully ready to support Python 3.14 for the PyArrow 22 release. ### What changes are included in this PR? This PR updates wheels for Python 3.14. ### Are these changes tested? Tested in the CI and with extended builds. ### Are there any user-facing changes? No, but users will be able to use PyArrow with Python 3.14. * GitHub Issue: #47438 --- Todo: - Update the image revision name in `.env` - Add 3.14 conda build ([arrow/dev/tasks/tasks.yml](https://github.com/apache/arrow/blob/d803afcc43f5d132506318fd9e162d33b2c3d4cd/dev/tasks/tasks.yml#L809)) when conda-forge/pyarrow-feedstock#156 is merged Follow-ups: - #47437 Authored-by: AlenkaF <[email protected]> Signed-off-by: AlenkaF <[email protected]>
…3.14 (apache#47616) ### Rationale for this change Python 3.14 is currently in a prerelease status and is expected to have a final release in October this year (https://peps.python.org/pep-0745/). We should ensure we are fully ready to support Python 3.14 for the PyArrow 22 release. ### What changes are included in this PR? This PR updates wheels for Python 3.14. ### Are these changes tested? Tested in the CI and with extended builds. ### Are there any user-facing changes? No, but users will be able to use PyArrow with Python 3.14. * GitHub Issue: apache#47438 --- Todo: - Update the image revision name in `.env` - Add 3.14 conda build ([arrow/dev/tasks/tasks.yml](https://github.com/apache/arrow/blob/d803afcc43f5d132506318fd9e162d33b2c3d4cd/dev/tasks/tasks.yml#L809)) when conda-forge/pyarrow-feedstock#156 is merged Follow-ups: - apache#47437 Authored-by: AlenkaF <[email protected]> Signed-off-by: AlenkaF <[email protected]>
Bot is stuck on missing dependencies; numba (needed for
sparse) will take a while yet to support 3.14.