Skip to content

Recipe for v1.0.1#43

Closed
maresb wants to merge 2 commits into
conda-forge:1.0.xfrom
maresb:v1.0.1
Closed

Recipe for v1.0.1#43
maresb wants to merge 2 commits into
conda-forge:1.0.xfrom
maresb:v1.0.1

Conversation

@maresb
Copy link
Copy Markdown
Contributor

@maresb maresb commented Aug 25, 2021

Closes conda-forge/msal_extensions-feedstock#12

Two blockers before merging this:

  1. I want to merge into a separate branch.
  2. The test tests:test_with_timeout() is failing locally (Linux) and I'm not sure why. (Don't have time right now to diagnose it.)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@maresb
Copy link
Copy Markdown
Contributor Author

maresb commented Aug 25, 2021

@conda-forge-admin, please rerender

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@tyrius02
Copy link
Copy Markdown
Contributor

@maresb You ask good questions and I'm just learning how all of this works. I think you took the right approach creating a fork, branching that fork, and working on the changes. I expect the process will be the same here as it has been elsewhere. With semantic versioning conda should resolve to the latest version of a package that satisfies all of the requested constraints.

I've asked in gitter.im if we follow the process as usual. In the meantime, we need to get those tests figured out.

@maresb
Copy link
Copy Markdown
Contributor Author

maresb commented Aug 26, 2021

Hi @tyrius02, the official process is very briefly documented here under Maintaining several versions.

The conda-forge infrastructure can handle whatever. I've even done similar stuff before with (re-)rendering previous versions. There I made mistakes and learned a lot about building old versions on conda-forge, and I can confidently say that a branch for each version which is revised out-of order is the way to go.

If you could just create a new branch named v1.0.1 with the same head as master then I could retarget this PR to that branch and we can check off point 1 in my description up top.

I've never directly used portalocker, so I am not sure what's going on with tests:test_with_timeout(). I also see that another test is failing on Windows. :(

@tyrius02 tyrius02 changed the base branch from master to 1.0.x August 26, 2021 12:23
@tyrius02
Copy link
Copy Markdown
Contributor

I've created a 1.0.x branch and re-targeted this PR.

@maresb
Copy link
Copy Markdown
Contributor Author

maresb commented Aug 26, 2021

Ah, this PR is now pointless because I couldn't properly read semver. 🤦‍♂️ Sorry for troubling you, @tyrius02, I'm closing this now. Feel free to delete the branch.

@maresb maresb closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants