Skip to content

Request to become maintainer#42

Closed
maresb wants to merge 2 commits into
conda-forge:mainfrom
maresb:add-maintainer
Closed

Request to become maintainer#42
maresb wants to merge 2 commits into
conda-forge:mainfrom
maresb:add-maintainer

Conversation

@maresb
Copy link
Copy Markdown
Contributor

@maresb maresb commented Aug 25, 2021

I'd like to make a build of v1.0.1 which is required for conda-forge/msal_extensions-feedstock#12 (comment).

In order to do this, the correct procedure is to make a new branch called v1.0.1. But as a non-maintainer, I don't know of any way to open a PR into a non-existing branch. Hence my request to either become a maintainer.

Alternatively, a maintainer could create a branch of that name, and I could then direct a PR to that.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

(No need to bump build number for adding a maintainer since it doesn't require a new build.)

@maresb maresb requested review from sodre and tyrius02 as code owners August 25, 2021 21:11
@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@maresb
Copy link
Copy Markdown
Contributor Author

maresb commented Aug 25, 2021

@conda-forge-admin, please rerender

@tyrius02
Copy link
Copy Markdown
Contributor

Read https://conda-forge.org/#update_recipe to learn how to contribute.

  1. Fork this repo
  2. Create a branch in your fork for the new version (I. e. v1.0.1)
  3. Update the recipe in your branch (version, sha256)
  4. Commit the changes and push
  5. Create a PR to merge the branch in your fork back to main in this repo

@maresb
Copy link
Copy Markdown
Contributor Author

maresb commented Aug 25, 2021

@tyrius02 but then after you merge, main (actually master) would be on v1.0.1, no? The git history would go v2.3.0 → v1.0.1 → v2.3.1 which would be very confusing, especially with changing the requirements back and forth. Thus the standard procedure in this case is to build old versions on a separate branch to avoid this jumping around.

@maresb maresb closed this Aug 26, 2021
@maresb maresb reopened this Nov 21, 2021
@maresb
Copy link
Copy Markdown
Contributor Author

maresb commented Nov 21, 2021

@conda-forge-admin, please rerender

@maresb
Copy link
Copy Markdown
Contributor Author

maresb commented Jun 18, 2022

Giving up.

@maresb maresb closed this Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants