openmp v19.1.0#144
Conversation
…ForgeAutomergeUpdate
This reverts commit 61a838f.
…nda-forge-pinning 2024.07.26.18.03.15
…nda-forge-pinning 2024.07.26.18.03.15
openmp v19.1.0.rc1
This reverts commit 8b23b90.
[dev] Actually enable fortran bits on windows
openmp v19.1.0.rc2
…nda-forge-pinning 2024.08.20.23.21.46
automerged PR by conda-forge/automerge-action
automerged PR by conda-forge/automerge-action
|
Windows builds here will need flang 19 to be built (exceptionally, as we're adding the fortran bits now, c.f. #134; for LLVM 20+ we shouldn't need the newest flang to build openmp) |
|
@conda-forge/openmp, aside from waiting for the flang builds on windows, this is ready, PTAL! :) |
This reverts commit 5a10fd7.
|
@conda-forge/openmp, this is ready now, PTAL! :) |
|
Kind ping @conda-forge/openmp, PTAL. |
|
Ping @conda-forge/openmp. Given that #134 (for the meat of the change here) received no comments in >2 months, I'm going to merge this in roughly 24h, unless there are other comments. |
|
Commented at #134 (comment) |
Thanks. I'm answering here because based on the comments I don't think we want to backport this feature to 18.x
I can try - currently assuming this can be done in a separate output here. How would you like to name this output? |
|
|
Should we move GCC's Edit: had some leftover text in my phone's editor, sorry |
Ping @isuruf |
Can you give an example of how |
Building openblas with openmp support (conda-forge/openblas-feedstock#115) failed without the |
|
Can you be more specific? The PR is green |
That PR doesn't build the llvm variant for openmp on linux. But it's green on windows because of the changes in this PR (as present in the dev/rc builds). I'm happy to descope the Fortran bits on Unix, but we need them on windows. |
|
Okay, then. Please remove the Unix parts. |
OK, sounds good. Do we still need to have the separation into separate outputs then? |
Yep, to avoid having to do that in the future if/when unix builds get added. |
Could we defer the separate output until such time when unix builds get added, or at least after the 19.1.0 release (I'd be willing to open a PR)? |
|
Can we drop the .mod files all ogether, get the 19 release out and deal with it later? |
OK. The flang migration on windows still needs them, but that's yet another separate milestone before the mod files ever become relevant on unix. |
ef03597 to
2b912c0
Compare
|
As this is now a vanilla version update (and we discussed "get the 19 release out" without the |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.