Skip to content

onnxruntime v1.21.1#145

Merged
hmaarrfk merged 5 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:1.21.1_h56361e
May 4, 2025
Merged

onnxruntime v1.21.1#145
hmaarrfk merged 5 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:1.21.1_h56361e

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #141
Closes: #143

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
protobuf 30.2 Anaconda-Server Badge

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/14585922928 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Apr 22, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14621504567. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Apr 23, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14640324609. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Apr 24, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14794080710. Examine the logs at this URL for more detail.

@hmaarrfk
Copy link
Contributor

@traversaro are you able to build for windows cuda?

or anybody else at @conda-forge/onnxruntime

@traversaro
Copy link
Contributor

@traversaro are you able to build for windows cuda?

or anybody else at @conda-forge/onnxruntime

I can try, I never did local builds for Windows packages but let's try to start one and see how it does.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 27, 2025

something like

set CONDA_OVERRIDE_CUDA=12.6
conda build -m .ci_support\win.... recipe | tee win_python3.XX.log.txt

should work. Sigh. i forgot to set the environment variable and just wasted 4 hours myself....

@traversaro
Copy link
Contributor

I tried with :

python build-locally.py win_64_cuda_compilercuda-nvcccuda_compiler_version12.6numpy2.0python3.10.____cpythonsuffix > onnxruntime1211py310cuda126.txt 2>&1

and it worked fine, but I had to use the laptop and the build process made it unusable. I will try once I do not need to use the laptop for a longer period of time.

@hmaarrfk
Copy link
Contributor

lol i thought i had a build last night, but my computer decided to go to sleep. gg.

It basically takes 1-2 hours to get from 1532 -> 1649/1649 files to compile

@hmaarrfk hmaarrfk mentioned this pull request Apr 30, 2025
3 tasks
@hmaarrfk
Copy link
Contributor

logs are showing:

[1309/1323] Linking CXX executable onnxruntime_mlas_q4dq
lto-wrapper: warning: using serial compilation of 5 LTRANS jobs
lto-wrapper: note: see the '-flto' option documentation for more information
$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/13.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: warning: QgemmU8S8KernelAmx.S.o: missing .note.GNU-stack section implies executable stack
$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/13.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
[1310/1323] Linking CXX executable onnx_test_runner
lto-wrapper: warning: using serial compilation of 128 LTRANS jobs
lto-wrapper: note: see the '-flto' option documentation for more information
$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/13.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: warning: QgemmU8S8KernelAmx.S.o: missing .note.GNU-stack section implies executable stack
$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/13.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
[1311/1323] Linking CXX shared module onnxruntime_pybind11_state.so
lto-wrapper: warning: using serial compilation of 128 LTRANS jobs
lto-wrapper: note: see the '-flto' option documentation for more information
$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/13.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: warning: QgemmU8S8KernelAmx.S.o: missing .note.GNU-stack section implies executable stack
$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/13.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

which means we do in fact need #147

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 2, 2025

I would really like to get this through, mostly for Ubuntu 25.04 compatibility.

@traversaro i see that your packages are the only ones that depend on the onnxruntime-cpp at conda-forge.

What timeframe do you think is acceptable for us to wait for CFEP03?

@traversaro
Copy link
Contributor

I would really like to get this through, mostly for Ubuntu 25.04 compatibility.

@traversaro i see that your packages are the only ones that depend on the onnxruntime-cpp at conda-forge.

What timeframe do you think is acceptable for us to wait for CFEP03?

As you mentioned in conda-forge/cfep#62, I think ~1 week is a perfectly reasonable time. I typically instruct users at my organization to explicitly depend on the cuda build string instead of just blindly trusting that new releases of packages will always come out with cuda support out of the box exactly for this scenario, so if we do not have the capacity at the moment to mantain onnxruntime-cpp with CUDA on Windows, I think it make perfect sense to just drop it.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 3, 2025

its more that i anticipate a migration to be started on onnxruntime-cpp since it exposes and ABI.

Good to hear that you think you might not be affected so severely by this.

I do use use onnxruntime with windows as well, but i think the "old release" is more than enough, until i get time to get around to fixing it.

I want to keep restarting until the linux biulds are green, then merge.

We can then keep a tracking issue open so we can coordinate on getting the latest release built together. over time...

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 4, 2025

Built 3.12.

Trying to build 3.11 and 3.10 at the same time. Hopefully I’ll be able to start 3.13 at night today too

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 4, 2025

win_python_log.zip

@hmaarrfk hmaarrfk merged commit 03844d5 into conda-forge:main May 4, 2025
54 of 59 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 1.21.1_h56361e branch May 4, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants