Skip to content

add myself to the maintainers#27

Merged
xhochy merged 1 commit intoconda-forge:masterfrom
henryiii:patch-1
Feb 18, 2022
Merged

add myself to the maintainers#27
xhochy merged 1 commit intoconda-forge:masterfrom
henryiii:patch-1

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

In the near future, I'd like to look at adding the ninja python module from our scikit-build to this feedstock - it likely would help with scikit-build/scikit-build#666. CC @frol.

@henryiii henryiii requested review from frol and xhochy as code owners February 18, 2022 16:39
@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Feb 18, 2022

What is the ninja python module ?

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Feb 18, 2022

@henryiii Happy to add you but I don't want a Python dependency here. As far as I understand, https://pypi.org/project/ninja/ is just a binary repack of a statically compiled ninja. We wouldn't like to have this as such in conda-forge as this introduce an unnecessary dependency on Python.

@henryiii
Copy link
Copy Markdown
Contributor Author

henryiii commented Feb 18, 2022

It's https://github.com/scikit-build/ninja-python-distributions/tree/master/src/ninja and it's what you get when you pip install ninja or put ninja in requirements - just a small wrapper on top of ninja that allows it to be run from Python without having to worry about paths. scikit-build will automatically detect it and use it if it is present. If it introduces a dependency, maybe a split feedstock with two outputs would work? Also okay to leave it off if it causes issues.

Edit: yes, it's also a binary repack of a statically compiled ninja, but I don't think that is useful/needed, it would just potentially be nice to have the Python wrapper for consistency with the ninja PyPI module. I could make sure it was able to be used with an externally compiled Ninja if needed. Also okay to leave it off if not helpful, though it's been asked for in scikit-build/ninja-python-distributions#42 and #26.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Feb 18, 2022

I think the best approach would be to create a new feedstock called python-ninja that depends on this feedstock here for the actual binary and ships the Python files. This will be much easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants