Fix build#160
Merged
akrherz merged 8 commits intoconda-forge:mainfrom Apr 9, 2025
Merged
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Contributor
Author
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2025.04.02.21.55.06
bouweandela
commented
Apr 8, 2025
| - udunits2 | ||
| - zlib | ||
| - esmf <8.6.0 | ||
| - esmf * mpi_* |
Contributor
Author
There was a problem hiding this comment.
If I understand it correctly, loading a grid from file is done using this function which requires parallelio which is only available in the mpi builds.
bouweandela
commented
Apr 8, 2025
| ;---Checking if the user specifies that source grid is ESMF | ||
| if (isatt_logical_true(opt2,"SrcESMF")) then | ||
| - ESMFCMD = ESMFCMD + " --src_type ESMF" | ||
| + ESMFCMD = ESMFCMD + " --src_type ESMFMESH" |
Contributor
Author
5 tasks
bouweandela
commented
Apr 8, 2025
|
|
||
| - if [[ $compare_ret -eq 0 ]]; then | ||
| + if [[ $(echo "$METRIC < 10^-5" | sed 's/e-0*/*10^-/' |bc -l) -eq 1 ]]; then | ||
| + if [[ $(echo "$METRIC < 10^-5" | sed -E 's/.*\((.+)\)/\1/' | sed 's/e-0*/*10^-/' |bc -l) -eq 1 ]]; then |
Contributor
Author
There was a problem hiding this comment.
Output format of compare -metric DSSIM has changed from 9.8793e-07 to 0.064744 (9.8793e-07) on recent versions of imagemagick
bouweandela
commented
Apr 8, 2025
| - coreutils | ||
| - git | ||
| - imagemagick | ||
| - imagemagick !=7.1.1_47 |
Contributor
Author
There was a problem hiding this comment.
bouweandela
requested review from
akrherz,
david-ian-brown,
erogluorhan,
khallock,
marylhaley,
ocefpaf,
xylar and
zklaus
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Closes #154
Closes #156
Closes #157
Closes #158
Fix the build