Skip to content

Convert to v1 and bump to 0.5.5#17

Merged
hadim merged 31 commits into
conda-forge:mainfrom
hadim:convert
Jan 28, 2025
Merged

Convert to v1 and bump to 0.5.5#17
hadim merged 31 commits into
conda-forge:mainfrom
hadim:convert

Conversation

@hadim

@hadim hadim commented Jan 28, 2025

Copy link
Copy Markdown
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin

conda-forge-admin commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

  • ℹ️ Jinja2 variable references are suggested to take a ${{<one space><variable name><one space>}} form. See lines [20].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13013118814. Examine the logs at this URL for more detail.

This was referenced Jan 28, 2025
@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@hadim

hadim commented Jan 28, 2025

Copy link
Copy Markdown
Member Author

linux aarch64 could works once conda-forge/cuda-nvcc-feedstock#59 is fixed

@hadim

hadim commented Jan 28, 2025

Copy link
Copy Markdown
Member Author

note that the cmake python install is using python setup.py instead of pip. all good for now but it might be failing in the future. in that case, simply patch the cmake python install with pip install.

@hadim hadim merged commit 15b03f7 into conda-forge:main Jan 28, 2025
@hadim hadim deleted the convert branch January 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants