Revert to using Maintainer-Provided sources, configure the bot to only use the RawURL Version Source#275
Revert to using Maintainer-Provided sources, configure the bot to only use the RawURL Version Source#275ytausch wants to merge 5 commits into
Conversation
this should prevent conda-forge/conda-forge-bot#2531 from happening again
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
I really don't see the benefit of this (for me it has more disadvantages if anything), but if other people really prefer it like this, I won't stand in the way. 🤷♂️ I can already say though that the moment the bots start failing to issue update PRs again across the LLVM stack, this will be reverted, because right now it works without issue. |
Just to be clear: I am not a strong advocate of this either because the GitHub-generated tarballs really work most of the time and we are adding complexity with this. But since @jakirkham mentioned the benefits of using the maintainer-provided sources and I don't really have to say anything against them, we should at least give it a try.
Yes, absolutely. |
|
Thought we are open to trying better solutions ( conda-forge/conda-forge-bot#2531 (comment) )? If so, then yes let's try this If it doesn't work, we are just back where we started. And if it does, great we have found a reasonable solution |
I'm open, despite considering it a worse solution which requires churn and introduces further drain on attention ("did it work?"), because it's not a discussion I consider worth spending time on. Feel free to merge if the change is important to you. |
|
We can try it on one feedstock to start (could be this one or could be a different one) That way we have comparative data between the current and new approach Would that be easier to keep tabs on? |
Fine by me. I'd prefer it to be another feedstock, because this one absolutely needs to be built the earliest, otherwise no other pieces of the LLVM stack can be built (so missing |
|
Great let's do |
…wURL version source xref: conda-forge/llvmdev-feedstock#275
|
Going to turn this into a draft while we wait and see how the experiment with mlir-python-bindings works out. There won't be another release before LLVM 19.1.0 in September, so we have a little while to wait. |
|
It has been a few months since this experiment began. Looks like the bot generated a couple PRs:
What do we think? |
You can try rolling it out across more feedstocks (see all the ones opened by the bot that are mentioned in conda-forge/clang-compiler-activation-feedstock#142 for example). I still dislike maintainer-provided sources more than Github-generated tarballs (compare the recent xz drama where this was the attack vector), but I'm OK to let this point go if our infra opens PRs on time (and assuming upstream doesn't start having large lags between the tag creation and the upload of their |
|
@conda-forge-admin , please re-render |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15123381750. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15122529045. Examine the logs at this URL for more detail. |
Bump build number given source changed.
Checklist
Bumped the build number (if the version is unchanged)I did not bump the build number as the output should not change.0(if the version changed)Re-rendered with the latestconda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Configuring the bot to only use the RawURL version updater should allow us to use the maintainer-provided sources again, which has some benefits as GitHub-generated source tarballs are sometimes unstable.
See conda-forge/conda-forge-bot#2531 (comment)
If this is approved, I will also create PRs at our other LLVM repos.