Skip to content

Build on Windows#7

Closed
jakirkham wants to merge 11 commits into
conda-forge:masterfrom
jakirkham-feedstocks:bld_win
Closed

Build on Windows#7
jakirkham wants to merge 11 commits into
conda-forge:masterfrom
jakirkham-feedstocks:bld_win

Conversation

@jakirkham
Copy link
Copy Markdown
Member

Fixes #4

Drops the skip and starts building on Windows.

@conda-forge-admin, please re-render.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

jakirkham added 2 commits May 13, 2018 13:16
Try to match indenting in the rest of the recipe.
Simply drop the `skip` on Windows to try and get Windows builds going.
Everything else should already be in place.
@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham mentioned this pull request May 13, 2018
conda-forge-admin and others added 5 commits May 13, 2018 17:22
In `conda-build` 3 the location of `cmake` will be different as it is a
`build` not a `host` dependency. In either case though, it should be on
the path. So specifying the exact path to where `cmake` is should not be
necessary.
@jakirkham
Copy link
Copy Markdown
Member Author

Seems to failing. Any ideas?

CMake Error at CMakeLists.txt:84 (add_library):
  Cannot find source file:
    lib/collect.c
  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx
CMake Error at CMakeLists.txt:84 (add_library):
  No SOURCES given to target: THEORA

ref: https://ci.appveyor.com/project/conda-forge/libtheora-feedstock/build/1.0.5

jakirkham added 2 commits May 13, 2018 14:05
Appears some files listed as sources were missing or in some cases a few
were left out. This corrects those issues.
jakirkham added 2 commits May 13, 2018 14:16
Appears that `sse2fdct.c` is not in `x86_vc`. So drop it from the listed
sources in the `x86_vc` directory.
@jakirkham
Copy link
Copy Markdown
Member Author

Appears we cannot use inline assembly with Visual Studio on 64-bit. Not sure how to proceed. 😕

ref: https://stackoverflow.com/a/14292031
ref: https://ci.appveyor.com/project/conda-forge/libtheora-feedstock/build/1.0.9

@ihnorton
Copy link
Copy Markdown

ihnorton commented Oct 5, 2018

vcpkg has a working CMakeList for theora:

https://github.com/Microsoft/vcpkg/blob/master/ports/libtheora/CMakeLists.txt

big differences are they build the VC-specific fragments from lib/x86_vc, and only set -DOC_X86_AS on x86.

@jakirkham
Copy link
Copy Markdown
Member Author

This was addressed in PR ( #10 ). Closing...

@jakirkham jakirkham closed this Jun 24, 2020
@jakirkham jakirkham deleted the bld_win branch June 24, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows support

4 participants