Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jpeg virtual package #15

Closed
wants to merge 3 commits into from
Closed

Conversation

jschueller
Copy link

@jschueller jschueller commented Jan 21, 2020

like this @isuruf ?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'jpeg' output doesn't have any tests.

@isuruf isuruf changed the title Create jpeg virtual package [WIP] [NO MERGE] Create jpeg virtual package Jan 21, 2020
@isuruf
Copy link
Member

isuruf commented Jan 21, 2020

libjpeg.8.dylib from this package has (compatibility version 8.0.0, current version 8.2.2) while the one from jpeg package has (compatibility version 13.0.0, current version 13.0.0). This has to be fixed before merging this.

@jschueller
Copy link
Author

@isuruf ok

@isuruf
Copy link
Member

isuruf commented Feb 4, 2020

Changing the soversion like this fixes the current-version and comaptibility-version, but breaks the install name.

@jakirkham
Copy link
Member

How would you recommend we proceed then?

@ericpre
Copy link
Member

ericpre commented Apr 24, 2020

Thanks @jschueller for tackling this! Since this seems to be a tricky, could one of the conda-build/conda-forge wizards helps with some tricks?

This is one blocker for packaging imagecodecs: conda-forge/staged-recipes#10331.

recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Jun 1, 2020

Changing the soversion like this fixes the current-version and comaptibility-version, but breaks the install name.

Could we mark all the old builds as broken? does anything actually use jpeg-turbo as of today?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'jpeg' output doesn't have any tests.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@jschueller
Copy link
Author

@conda-forge-admin please rerender

@jschueller jschueller changed the title [WIP] [NO MERGE] Create jpeg virtual package Create jpeg virtual package Jun 1, 2020
@jschueller
Copy link
Author

@isuruf I fixed the compatibility/current version property, I believe this is ready for review

@isuruf
Copy link
Member

isuruf commented Jun 4, 2020

Let's continue the discussion at conda-forge/conda-forge.github.io#673

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'jpeg' output doesn't have any tests.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@jschueller
Copy link
Author

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 8, 2023

i think we can close this.

Thank you for helping get to this stage!

@carlodri carlodri closed this Mar 8, 2023
@hmaarrfk hmaarrfk reopened this Mar 15, 2023
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'jpeg' output doesn't have any tests.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@jschueller jschueller closed this Apr 7, 2023
@jschueller jschueller deleted the virtual branch April 7, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants