Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternate libint2 for psi4 #17

Merged
merged 7 commits into from
Mar 14, 2023
Merged

alternate libint2 for psi4 #17

merged 7 commits into from
Mar 14, 2023

Conversation

loriab
Copy link
Contributor

@loriab loriab commented Feb 23, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This is based on the discussion in #15 and uses the recipe from staged-recipes. I'm trying this as a dev package so that it doesn't disrupt current users and doesn't put non-upstream-merged code on main c-f channel. Experimenting for now.

closes conda-forge/staged-recipes#22060
closes #15
closes #16
closes loriab/psi4-binder#3
closes loriab/psi4-binder#36
closes loriab/psi4-binder#38

@loriab loriab requested a review from felipeZ as a code owner February 23, 2023 22:37
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • pin_compatible should be used instead of pin_subpackage for libint2 because it is not a known output of this recipe: ['libint'].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@loriab
Copy link
Contributor Author

loriab commented Feb 23, 2023

@conda-forge-admin, please rerender

@loriab
Copy link
Contributor Author

loriab commented Feb 24, 2023

I guess this is plausibly ready for review @felipeZ . Glad to answer any questions.

@loriab loriab mentioned this pull request Mar 10, 2023
@felipeZ felipeZ merged commit 424c591 into conda-forge:dev Mar 14, 2023
@loriab loriab deleted the post1 branch March 14, 2023 20:20
@loriab loriab mentioned this pull request Mar 20, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants