Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build #5

Merged
merged 8 commits into from
Mar 16, 2020
Merged

Windows build #5

merged 8 commits into from
Mar 16, 2020

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Jan 1, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 1, 2020

@conda-forge/help-c-cpp

Any idea why with VC2008, the library files are libaec.lib and with VC2015 they are aec.lib?

I could just skip the old 2008 build.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 1, 2020

@conda-forge-admin please rerender

@kmuehlbauer
Copy link
Contributor

@hmaarrfk Would you mind adding yourself as maintainer. I'm not a Windows guy so I would appreciate your support.

@hmaarrfk
Copy link
Contributor Author

done.

Ultimately. i just want to be able to install imagecodecs on conda-forge.

That package is so hard to build....

@kmuehlbauer
Copy link
Contributor

Thanks, similar here, needed it for eccodes package.

Let's have a look how this bot merge works.

@kmuehlbauer kmuehlbauer added the automerge Merge the PR when CI passes label Mar 16, 2020
@github-actions github-actions bot merged commit ca37273 into conda-forge:master Mar 16, 2020
@hmaarrfk hmaarrfk deleted the windows_build branch March 16, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants