Skip to content

Carry some upstream patches (that were pending for #32)#41

Merged
isuruf merged 5 commits into
conda-forge:masterfrom
h-vetinari:master
Oct 22, 2020
Merged

Carry some upstream patches (that were pending for #32)#41
isuruf merged 5 commits into
conda-forge:masterfrom
h-vetinari:master

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I had a couple more commits prepared for #32, based on following the PRs of Reference-LAPACK/lapack and xianyi/OpenBLAS, but hadn't pushed them yet as that PR was still waiting for a decision of how to deal with 3.9.0. Now that it's merged, opening another PR for that.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libblas' output doesn't have any tests.
  • It looks like the 'libcblas' output doesn't have any tests.
  • It looks like the 'liblapack' output doesn't have any tests.
  • It looks like the 'liblapacke' output doesn't have any tests.
  • It looks like the 'blas-devel' output doesn't have any tests.
  • It looks like the 'lapack' output doesn't have any tests.

@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @isuruf

@isuruf isuruf merged commit a6177d1 into conda-forge:master Oct 22, 2020
@isuruf

isuruf commented Oct 22, 2020

Copy link
Copy Markdown
Member

Thanks

@h-vetinari

Copy link
Copy Markdown
Member Author

Just noticing that merging this after #42 without rebasing caused the build number not to be bumped.

@h-vetinari h-vetinari mentioned this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants