Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

This PR was created by the cf-regro-autotick-bot.

The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. It is very likely that the current package version for this feedstock is out of date or needed migration.

Notes and instructions for merging this PR:

  1. Please check that the dependencies have not changed.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.
  4. The bot will almost always only open one PR per version.

If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@DPeterK
Copy link
Contributor

DPeterK commented Jun 8, 2018

@ocefpaf we could do with moving this forward real soon... is there any chance you can assist with this? Note that the recipe isn't quite there yet as @regro-cf-autotick-bot missed the version updates needed:

  • cf_units >=2
  • cftime as a new dependency (build and run)
  • matplotlib >=2
  • numpy >=1.14

I tried to push a commit to the bot's branch to make these changes... but given that I don't have merge rights, assumedly I don't have those push rights either.

Thanks!

- pip
- cartopy >=0.14
- cf_units
- cf_units >=2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that is the status of the rename here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf what do you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah – I've been keeping clear of that conversation!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I was too late :-(

- rhattersley
- ocefpaf
- bjlittle
- dkillick
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkillick this will give you commit rights to this feedstock.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff on this @dkillick!

As ever, thanks @ocefpaf!

recipe/meta.yaml Outdated
run:
- python
- cartopy >=0.14
- cf_units
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf think this cf_units needs a version update too...

- pip
- cartopy >=0.14
- cf_units
- cf_units >=2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf what do you mean?

@DPeterK
Copy link
Contributor

DPeterK commented Jun 8, 2018

Woop the tests all pass with the updates to meta.yaml 😀

@ocefpaf ocefpaf merged commit 43ad92f into conda-forge:master Jun 8, 2018
@DPeterK
Copy link
Contributor

DPeterK commented Jun 8, 2018

Fantastic 😁 Thanks @ocefpaf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants