Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH updated version to 12.0.0 #81

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started a version update as instructed in #80.

I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!

Fixes #80

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] added 2 commits March 25, 2024 12:53
@traversaro traversaro changed the title ENH: update package version ENH updated version to 12.0.0 Mar 25, 2024
@traversaro traversaro added the automerge Merge the PR when CI passes label Mar 25, 2024
@traversaro
Copy link
Contributor

Now all the jobs fail on the Visualizer test:

56/66 Test #56: UnitTestVisualizer ....................................***Failed    0.93 sec
[ERROR] Visualizer :: init : Could not create window
[ERROR] Visualizer :: addModel : Error in initializing Irrlicht device
%SRC_DIR%\src\visualization\tests\VisualizerUnitTest.cpp:17 : assertTrue failure

Interestingly, similar tests used to work fine before this PR, not sure if the modifications done to the tests by @S-Dafarra created this problem. However, the test was never run in the iDynTree CI (see robotology/idyntree#808), so I am surprise that instead we were running it in conda-forge and it was working. Anyhow, at this point I think it make sense to just skip it.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Mar 25, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@S-Dafarra
Copy link

Now all the jobs fail on the Visualizer test:

56/66 Test #56: UnitTestVisualizer ....................................***Failed    0.93 sec
[ERROR] Visualizer :: init : Could not create window
[ERROR] Visualizer :: addModel : Error in initializing Irrlicht device
%SRC_DIR%\src\visualization\tests\VisualizerUnitTest.cpp:17 : assertTrue failure

Interestingly, similar tests used to work fine before this PR, not sure if the modifications done to the tests by @S-Dafarra created this problem. However, the test was never run in the iDynTree CI (see robotology/idyntree#808), so I am surprise that instead we were running it in conda-forge and it was working. Anyhow, at this point I think it make sense to just skip it.

I think it is due to the fact that it tries to create a Window with GLFW. One thing to try would be to run in an emulated x environment, as in https://github.com/ami-iit/yarp-device-openxrheadset/blob/ad4ec150174ce527a2af0e909196c25350374c9b/.github/workflows/ci.yml#L136-L151

Still, no idea why it was working before

@traversaro
Copy link
Contributor

Still, no idea why it was working before

Indeed. Anyhow, we can use robotology/idyntree#808 to track the problem, for sure we can't have a test in the conda-forge CI if we do not have it enabled in the upstream CI.

@traversaro traversaro merged commit b11376c into conda-forge:main Mar 25, 2024
25 of 26 checks passed
@traversaro traversaro mentioned this pull request Mar 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please update version
3 participants