Windows builds are failing

[ocefpaf]

HDF5 is failing on Windows.

BUILD END: hdf5-1.8.16-vc9_0 
TEST START: hdf5-1.8.16-vc9_0 
Fetching package metadata: ........
Solving package specifications: ....
Error: The following specifications were found to be in conflict:
  - hdf5 1.8.16 vc9_0
Use "conda info <package>" to see the dependencies for each package.
Command exited with code 1

[jakirkham]

That is a very special error. I'm not really sure how we got into this situation.

[jakirkham]

I dropped it in the "I need help on Windows" issue so hopefully someone with a dev environment who knows more can figure this out. Were there any recent releases of conda as this was working before? Appears not.

[jakirkham]

Oh, maybe we need python as a testing requirement. Thoughts? I'll draw up a PR. Feedback welcome. 😄

[ocefpaf]

Oh, maybe we need python as a testing requirement. Thoughts? I'll draw up a PR. Feedback welcome. 😄

Makes sense... I guess...

If that works can you update the wiki?

https://github.com/conda-forge/staged-recipes/wiki/VC-features

[jakirkham]

Still weird that it worked before though. Maybe there is some subtle difference between CI here and in staged-recipes?

[msarahan]

Python should not be required in tests if it is required in run requirements. However, there is one crazy issue: Test requirements are NOT pinned the same way that run requirements are: conda/conda-build#835

I can't explain the inconsistent behavior, but it might be related to that issue.

[jakirkham]

Slowly coming back to me. We ran into this issue with GLPK. Maybe I need to tweak the recipe here to match. That or will need @pelson's CI improvements. Might want to wait to see how GLPK gets fixed before implementing something here. @jjhelmus @pelson, do either of you have any thoughts on this point?

[jjhelmus]

At least for GLPK adding python as a run requirement on Winodws fixed the build issue. I agree with the desire for a more elegant solution either with a msvc package or in conda build itself but until then the python run requirement will do the trick.

[ocefpaf]

@jakirkham I guess the original issue here is resolved, correct? I saw the logs and there is a new problem:

C:\conda\conda-bld\test-tmp_dir>where h5c++ 
INFO: Could not find files for the given pattern(s).

C:\conda\conda-bld\test-tmp_dir>if errorlevel 1 exit 1 

I believe that has a simple solution (missing .exe extension).

[jakirkham]

So, I think the problem is that executable doesn't exist on Windows. Not sure why that is. However, if you look earlier in the log, you will see that never copied over into the binaries' directory.

[jakirkham]

Yeah, appears these are UNIX only. Will fix the test and then it should be ok.

[jakirkham]

Think we have incorporated these fixes. Will see if it builds correctly this time.

[jakirkham]

Well, I ran CI under my own user and that fixed almost all issues except for 64-bit support with VS 2008. In other words, we require this fix ( conda-forge/conda-smithy#107 ). Sorry, I misspoke. This does not seem to be true. The build merely hung mysteriously immediately after cloning.

[jakirkham]

cc @pelson

[jakirkham]

I believe that I have fixed this problem. Here were the problems.

1. VC features were not being followed on Windows during testing.
2. UNIX only binaries were being searched for on Windows.
3. It appears that h5perf_serial is missing on Windows.

The first two make sense and have been fixed. Though given the issues with 1, it is possible it will resurface and will keep an eye open for bug reports there to see if we need a better fix. As for 3, this doesn't seem like it should be a problem and it is being built as one can see in the AppVeyor log; however, the test for it fails. Given I don't really have a Windows dev environment, I appreciate any help I can get on that point. My current plan is to inspect the Windows binaries (once available) to see if this is getting renamed somehow. However, I didn't want to hold up binaries that otherwise seem to work over this one missing command line tool.

[jakirkham]

Looks like Windows builds are released. 🎉