-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to add Windows support #1
Conversation
Don't merge as this is not even running on AppVeyor. |
re-render with conda smithy:
That will give you the appropriate CI scripts. |
Hi! This is the friendly conda-forge-admin automated user. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@@ -34,7 +34,7 @@ requirements: | |||
- numpy x.x | |||
- hdf5 | |||
- six | |||
- unittest2 #[py26] | |||
- unittest2 # [py26] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever. Seemed to have caught this issue.
Seem to be hitting a linking error on AppVeyor. This is the closest thing to a fix that I have seen. |
Looks like the cause is this line. |
Added a patch for the Windows build based on this comment by @cgohlke. Will look at how to get a proper option into |
🎉 Passing 🎉 Thanks everyone for your help. Now supporting Windows. 😄 |
Was part of the original proposal for this feedstock, but had to be ripped out as it wasn't working. May require a Windows dev to build off of this to get something workable.