Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to add Windows support #1

Merged
merged 7 commits into from
Apr 8, 2016
Merged

Try to add Windows support #1

merged 7 commits into from
Apr 8, 2016

Conversation

jakirkham
Copy link
Member

Was part of the original proposal for this feedstock, but had to be ripped out as it wasn't working. May require a Windows dev to build off of this to get something workable.

@jakirkham jakirkham changed the title Try to add Windows support WIP: Try to add Windows support Mar 25, 2016
@jakirkham
Copy link
Member Author

Don't merge as this is not even running on AppVeyor.

@pelson
Copy link
Member

pelson commented Mar 26, 2016

re-render with conda smithy:

conda smithy rerender

That will give you the appropriate CI scripts.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a " # []" form.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@@ -34,7 +34,7 @@ requirements:
- numpy x.x
- hdf5
- six
- unittest2 #[py26]
- unittest2 # [py26]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever. Seemed to have caught this issue.

@jakirkham
Copy link
Member Author

Seem to be hitting a linking error on AppVeyor. This is the closest thing to a fix that I have seen.

@jakirkham
Copy link
Member Author

Looks like the cause is this line.

@jakirkham
Copy link
Member Author

Added a patch for the Windows build based on this comment by @cgohlke. Will look at how to get a proper option into h5py to enable this functionality.

@jakirkham jakirkham changed the title WIP: Try to add Windows support Try to add Windows support Apr 8, 2016
@jakirkham
Copy link
Member Author

🎉 Passing 🎉

Thanks everyone for your help.

Now supporting Windows. 😄

@jakirkham jakirkham merged commit b2caab9 into conda-forge:master Apr 8, 2016
@jakirkham jakirkham deleted the add_windows branch April 8, 2016 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants