Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glm to v0.9.9.8 #15

Merged
merged 12 commits into from
May 3, 2023
Merged

Update glm to v0.9.9.8 #15

merged 12 commits into from
May 3, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Feb 22, 2023

Based on #14 with additional fixes.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from mcs07 as a code owner February 22, 2023 13:13
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

traversaro commented Feb 22, 2023

The PR is ready for review @conda-forge/glm . I skipped the test test-core_func_integer only because it is a known failure upstream (see g-truc/glm#1087) and that also affects earlier version when compiled with GCC11 (see https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=662955&view=logs&jobId=656edd35-690f-5c53-9ba3-09c10d0bea97&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

@conda-forge/glm if you are interested in help in mantaing the package, I also added myself to the mantainers.

@traversaro
Copy link
Contributor Author

@conda-forge/glm if you are interested in help in mantaing the package, I also added myself to the mantainers.

@conda-forge/core The mantain of this feedstock did not replied for more than one week, can you merge this PR so that I can mantain it? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants