Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ABI fix #19

Closed
wants to merge 2 commits into from
Closed

Backport ABI fix #19

wants to merge 2 commits into from

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Nov 1, 2020

fmt 7.1.0 contains a breaking API change against 7.0.3. This breaks
packages that were built against version 7.*. This backports an upstream
patch that is not in a release yet that apparently reverts this ABI
change.

The upstream issue is here: fmtlib/fmt#1961

fmt 7.1.0 contains a breaking API change against 7.0.3. This breaks
packages that were built against version 7.*. This backports an upstream
patch that is not in a release yet that apparently reverts this ABI
change.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@saraedum saraedum changed the title Backport 4081b2fe948aec01a49cc6e231bee4e02df3d61e Backport ABI fix Nov 1, 2020
@saraedum
Copy link
Member Author

saraedum commented Nov 1, 2020

@conda-forge-admin please rerender

@github-actions
Copy link

github-actions bot commented Nov 1, 2020

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@saraedum
Copy link
Member Author

saraedum commented Nov 1, 2020

@vitaut @tdegeus do you agree that we should backport this patch? This of course breaks any packages that have built against fmt in the last six days (but they would be broken with future releases anyway). But it should fix all the ones that were built since July when the first 7.0 was packaged here.

@tdegeus
Copy link
Member

tdegeus commented Nov 2, 2020

I'm perfectly fine with back-porting it, also for those that already built, the build 0 will be available I think. I would prefer though that there'd be a patch release in fmt. That would be by far the most transparent. Can you comment @vitaut ?

@vitaut
Copy link

vitaut commented Nov 2, 2020

@saraedum
Copy link
Member Author

saraedum commented Nov 2, 2020

That's much better of course. I wasn't aware that we had the author as one of the feedstock maintainers :)

@saraedum saraedum closed this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants