-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport ABI fix #19
Backport ABI fix #19
Conversation
fmt 7.1.0 contains a breaking API change against 7.0.3. This breaks packages that were built against version 7.*. This backports an upstream patch that is not in a release yet that apparently reverts this ABI change.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. |
@vitaut @tdegeus do you agree that we should backport this patch? This of course breaks any packages that have built against fmt in the last six days (but they would be broken with future releases anyway). But it should fix all the ones that were built since July when the first 7.0 was packaged here. |
I'm perfectly fine with back-porting it, also for those that already built, the build 0 will be available I think. I would prefer though that there'd be a patch release in fmt. That would be by far the most transparent. Can you comment @vitaut ? |
https://github.com/fmtlib/fmt/releases/tag/7.1.1 is the patch release. |
That's much better of course. I wasn't aware that we had the author as one of the feedstock maintainers :) |
fmt 7.1.0 contains a breaking API change against 7.0.3. This breaks
packages that were built against version 7.*. This backports an upstream
patch that is not in a release yet that apparently reverts this ABI
change.
The upstream issue is here: fmtlib/fmt#1961