-
-
Notifications
You must be signed in to change notification settings - Fork 49
Example of pkgconf usage #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example of pkgconf usage #317
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13534727439. Examine the logs at this URL for more detail. |
|
@conda-forge-admin please rerender |
|
@traversaro sorry for the ping. But it seems that ffplay is not compiling anymore. Do you mind taking a look? is there a way to check if it is enabled at build time instead of test time |
No problem, I will check later this (european) evening. |
|
It could be a regression due to the update of sdl2 package to sdl2-compat. |
|
do you have a link to the feedstock? |
|
|
it does seem related since pinning to 2.30.10 seems to working, i'll let you debug this if thats ok.... |
Sure. |
|
If you want to proceed without being blocked as the later version are ABI compatible pinning the host sdl2 to an earlier version is perfectly fine. |
e80f3bf to
9444eb8
Compare
|
Thanks. That’s what I did just now. Rebased this branch on the newly merged main |
|
I did not double checked if this is the case, but I guess the problem could be related to conda-forge/sdl-feedstock#22 . |
|
shall we try pkgconf here? |
To be honest I am not sure if we want to go in the rabbit hole of understanding how to tell ffmpeg to use pkgconf instead of pkg-config (see discussion in conda-forge/conda-forge.github.io#1880 (comment)). I implemented a solution compatible with old pkg-config in conda-forge/sdl-feedstock#23 , hopefully it will fix the problem. |
Yes, and personally I would avoid doing that for all the feedstock that use pkg-config with sdl2. conda-forge/sdl-feedstock#23 should fix the issue, if that does not work I will look into it. |
if nobody experiments with pkgconf we will be doomed with pig-config for ever. I think this is a really good opportunity to do so…. |
Probably this is a bit OT, but I think it make sense to experiment with pkgconf, I would just experiment with it exactly in the way all the distros I am aware of (see list in the following) experimented/worked on it, that is by providing an alternative "pkg-config" package that provides a Example of switch from pkgconf to pkg-config: |
…nda-forge-pinning 2025.02.25.13.14.53
9444eb8 to
b3dc8a0
Compare
|
I think conda-forge is very unique in the heavy use of cross compilation and simultaneous support Linux + OSX + Windows. if anything were to accelerate the adoption of pkgconf, it would be "the ffmpeg used the compatibility layers we are proposing to rollout conda-forge wide". Otherwise the "conda-forge existance proof is missing". I think the only missing piece would be a package that uses pkg-config natively for windows???? (I just rebased and rerendered force push FYI) |
Sure, but to be honest I am not super-familiar with messing with the host files installed by other packages, that is why I would prefer to avoid that. It seems to me (but again, this is just my opinion, I am not stopping anyone to work on this) that starting with having a dual build of pkg-config package, the proper pkg-config one with higher priority/build number, and one with a lower priority with pkgconf, and the use the pkgconf one here (or in another repo that uses pkg-config) would be more sound as a way to test the switch to pkgconf. |
| PKGCONF_LINKED=0 | ||
| if [[ ! -f ${BUILD_PREFIX}/bin/pkg-config ]]; then | ||
| ln -s ${BUILD_PREFIX}/bin/pkgconf ${BUILD_PREFIX}/bin/pkg-config | ||
| PKGCONF_LINKED=1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@traversaro I think something like this is 'reasonable' while we know for a fact that it is worthwhile to create the conflict between packages.
Already we have revealed a usecase where cairo.h cannot be found??? Not sure if that is the actual error or an other problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this make sense. One of my doubts was how to ensure that the symlink did not resulted in a file that is part of the new package, but the trick of PKGCONF_LINKED + rm fixes that.
Are you saying that sdl2 depends on bugs that are specific to |
|
@conda-forge-admin please restart cis |
|
Windows is still failing but we are closer on linux |
I was referring to the fact that I would avoid having to manually specify |
It seems that the latest failing build was not using the build |
|
sweet lets leave this as an pkgconf example, and do the cleanup in #319 |
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #316.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.