Skip to content

Comments

Pre release v2.11.0rc2#75

Merged
valeriupredoi merged 5 commits intoconda-forge:rcfrom
ehogan:v2.11.0rc2
Jun 27, 2024
Merged

Pre release v2.11.0rc2#75
valeriupredoi merged 5 commits intoconda-forge:rcfrom
ehogan:v2.11.0rc2

Conversation

@ehogan
Copy link
Contributor

@ehogan ehogan commented Jun 27, 2024 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

conda-forge-webservices bot commented Jun 27, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ehogan
Copy link
Contributor Author

ehogan commented Jun 27, 2024

@conda-forge-admin, please rerender

valeriupredoi
valeriupredoi approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick note about compilers needing removal; also, you are not pinning ESMPy here, will you in the stable release or not at all? FWYI @schlunma

recipe/meta.yaml Outdated
- cartopy
- cf-units
- cftime
- compilers
Copy link
Contributor

@valeriupredoi valeriupredoi Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- compilers

Copy link
Contributor

@valeriupredoi valeriupredoi Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed anymore 👍

Copy link
Contributor Author

@ehogan ehogan Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed in ESMValGroup/ESMValCore#2419, but it didn't get cherry-picked onto the release branch! 😭 Should I go and cherry-pick this PR, then create a rc3?

Copy link
Contributor Author

@ehogan ehogan Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 448a951 😊

Copy link
Contributor

@valeriupredoi valeriupredoi Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah just remove it here, no need for yet another rc3 - cheers!

Copy link
Contributor Author

@ehogan ehogan Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thank you! Does that mean this can be merged now? 👼

Copy link
Contributor

@valeriupredoi valeriupredoi Jun 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one sec - how's the pin on esmpy look like? in rc1 it was - esmpy !=8.1.0,<8.6.0 - maybe not pin it extremo >8.6 but remove the <8.6 ie let it a bit more free

Copy link
Contributor Author

@ehogan ehogan Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin is the same as rc1 in this repository and in ESMValCore and what is currently in the release branch.

Copy link
Contributor

@valeriupredoi valeriupredoi Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK prob best to leave it that way - that means that the latest iris-esmf-regrid will have probable issues as per ESMValGroup/ESMValCore#2445 but I guess that's one way to find out, since iris-esmf devs never told us that their latest version works with older ESMPy's - I am most prob gonna build a build: 1 soon to get us rid of Python 3.9, so nay bother

@ehogan
Copy link
Contributor Author

ehogan commented Jun 27, 2024

also, you are not pinning ESMPy here, will you in the stable release or not at all? FWYI @schlunma

Ah, I guess I was assuming I wouldn't update the ESMPy pins at all for this release. Will that cause problems? Otherwise I will cherry-pick that PR now and create a rc3 👍

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Jun 27, 2024

Nice! Built with python: 3.12.4-h194c7f8_0_cpython conda-forge 🥳

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Jun 27, 2024

also, you are not pinning ESMPy here, will you in the stable release or not at all? FWYI @schlunma

Ah, I guess I was assuming I wouldn't update the ESMPy pins at all for this release. Will that cause problems? Otherwise I will cherry-pick that PR now and create a rc3 👍

quite the contrary, those pins are giving me headaches to get us Python 3.12 support for Tool - please don't add them, and don't tell @schlunma 😁

ehogan added 2 commits June 27, 2024 15:39
@ehogan
Remove compilers dependency
448a951
@ehogan
Merge branch 'v2.11.0rc2' of github.com:ehogan/esmvalcore-feedstock i…
089da94 
…nto v2.11.0rc2

* 'v2.11.0rc2' of github.com:ehogan/esmvalcore-feedstock:
  MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.2, and conda-forge-pinning 2024.06.27.10.52.52
@ehogan ehogan requested a review from valeriupredoi June 27, 2024 14:45
valeriupredoi
valeriupredoi requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry Emma, spotted another bitty issue looking at yer fork - the host Python needs to change as well - python >=3.9,<3.12 -> - python >=3.9

@ehogan
Copy link
Contributor Author

ehogan commented Jun 27, 2024

sorry Emma, spotted another bitty issue looking at yer fork - the host Python needs to change as well - python >=3.9,<3.12 -> - python >=3.9

Thanks @valeriupredoi; change made in 932e3b7 😊

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Jun 27, 2024

cheers, Emma! Will approve and merge as soon as the build tests go green 🟢

valeriupredoi
valeriupredoi approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brill! Thanks very much @ehogan 🍺

@valeriupredoi valeriupredoi merged commit 1b9bb8c into conda-forge:rc Jun 27, 2024
@ehogan ehogan deleted the v2.11.0rc2 branch June 27, 2024 15:24
@ehogan
Copy link
Contributor Author

ehogan commented Jun 27, 2024

Thanks @valeriupredoi! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valeriupredoi valeriupredoi valeriupredoi approved these changes

@bouweandela bouweandela Awaiting requested review from bouweandela bouweandela is a code owner

@nielsdrost nielsdrost Awaiting requested review from nielsdrost

@remi-kazeroni remi-kazeroni Awaiting requested review from remi-kazeroni

@schlunma schlunma Awaiting requested review from schlunma schlunma is a code owner

@sloosvel sloosvel Awaiting requested review from sloosvel

@zklaus zklaus Awaiting requested review from zklaus zklaus is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ehogan @valeriupredoi