Refresh CUDA 12 migrator#19
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cyrsoxs-feedstock/actions/runs/7498764272. |
Pull in latest changes from `conda-forge-pinning`. https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/cbccb41e313c017c1ad15db6c287e87aa57d54dd/recipe/migrations/cuda120.yaml
|
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.01.11.21.29.17
|
This is passing! 🎉 @conda-forge/cyrsoxs this is ready for review 🙂 |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
Fixes linter error and modernizes recipe.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.08.23.18.51.20
| # Vendor CUDA 12 migrator to use GCC 11. | ||
| # This is needed to workaround a pybind + GCC 12 + nvcc 12 bug | ||
| # xref: https://github.com/pybind/pybind11/issues/4606 | ||
| use_local: true |
There was a problem hiding this comment.
The issue referenced above was fixed in pybind11's 2.12.0 with this change: pybind/pybind11@3414c56
We included pybind11 2.12.0 in conda-forge some time ago: conda-forge/pybind11-feedstock#94
Given this have dropped this use_local: true (to devendor this migrator) and refreshed it to match the global migrator
Also re-rendered to update this feedstock
| cuda_compiler: | ||
| - nvcc | ||
| cuda_compiler_version: | ||
| - '11.2' |
There was a problem hiding this comment.
Earlier this year, CUDA 11.2 was dropped in conda-forge. Hence why this goes away in the re-render
|
@conda-forge-admin , please re-render |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cyrsoxs-feedstock/actions/runs/10542136421. |
|
@conda-forge-admin , please re-render |
Currently conda-forge is Python 3.8+. So Python 3.7 is already skipped.
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cyrsoxs-feedstock/actions/runs/10542157153. |
|
@conda-forge/cyrsoxs this is ready for review! 😄 |
|
@pbeaucage would you be able to look? 🙂 |
|
@jakirkham looks great, thank you! |
|
Thanks Dean! 🙏 |
Recently the CUDA 11.8 migrator was closed out ( conda-forge/conda-forge-pinning-feedstock#5340 ). As part of that it was determined a small updated was needed to the CUDA 12 migrator ( conda-forge/conda-forge-pinning-feedstock#5340 (comment) ). While this largely works for most feedstocks without changes, those that have
use_local: truewill have issues with re-rendering until the CUDA 12 migrator they have is updated. This PR pulls over those updates to fix re-rendering on the feedstock. Please let us know if you have any other questions.Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #18.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.
Fixes #18