Skip to content

Refresh CUDA 12 migrator#19

Merged
delongchamp merged 12 commits intoconda-forge:mainfrom
conda-forge-admin:conda_forge_admin_18
Aug 27, 2024
Merged

Refresh CUDA 12 migrator#19
delongchamp merged 12 commits intoconda-forge:mainfrom
conda-forge-admin:conda_forge_admin_18

Conversation

@conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Jan 12, 2024

Recently the CUDA 11.8 migrator was closed out ( conda-forge/conda-forge-pinning-feedstock#5340 ). As part of that it was determined a small updated was needed to the CUDA 12 migrator ( conda-forge/conda-forge-pinning-feedstock#5340 (comment) ). While this largely works for most feedstocks without changes, those that have use_local: true will have issues with re-rendering until the CUDA 12 migrator they have is updated. This PR pulls over those updates to fix re-rendering on the feedstock. Please let us know if you have any other questions.


Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #18.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #18

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cyrsoxs-feedstock/actions/runs/7498764272.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham jakirkham changed the title MNT: rerender Refresh CUDA 12 migrator Jan 12, 2024
@jakirkham
Copy link
Member

This is passing! 🎉

@conda-forge/cyrsoxs this is ready for review 🙂

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

Fixes linter error and modernizes recipe.
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

Comment on lines -5 to -8
# Vendor CUDA 12 migrator to use GCC 11.
# This is needed to workaround a pybind + GCC 12 + nvcc 12 bug
# xref: https://github.com/pybind/pybind11/issues/4606
use_local: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue referenced above was fixed in pybind11's 2.12.0 with this change: pybind/pybind11@3414c56

We included pybind11 2.12.0 in conda-forge some time ago: conda-forge/pybind11-feedstock#94

Given this have dropped this use_local: true (to devendor this migrator) and refreshed it to match the global migrator

Also re-rendered to update this feedstock

Comment on lines -7 to -10
cuda_compiler:
- nvcc
cuda_compiler_version:
- '11.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier this year, CUDA 11.2 was dropped in conda-forge. Hence why this goes away in the re-render

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cyrsoxs-feedstock/actions/runs/10542136421.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

Currently conda-forge is Python 3.8+. So Python 3.7 is already skipped.
@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cyrsoxs-feedstock/actions/runs/10542157153.

@jakirkham
Copy link
Member

@conda-forge/cyrsoxs this is ready for review! 😄

@jakirkham
Copy link
Member

@pbeaucage would you be able to look? 🙂

@delongchamp delongchamp merged commit 32a64dc into conda-forge:main Aug 27, 2024
@delongchamp
Copy link
Contributor

@jakirkham looks great, thank you!

@jakirkham
Copy link
Member

Thanks Dean! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@conda-forge-admin , please re-render

3 participants