Fix GCC 14 flags#151
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14500761856. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
| # switch over release flag style cleanly across compiler versions, see #98 | ||
| meson_release_flag: | ||
| - "--buildtype release" | ||
| - "-Dbuildtype=release" | ||
| - "-Dbuildtype=release" | ||
| - "-Dbuildtype=release" |
There was a problem hiding this comment.
When we did the change-over of the flags (from #98 originally; done in #121), you had wanted to do keep this separate across compiler versions. I guess we're now running into situations where going back to GCC 12 for some unrelated reason causes problems with the meson flags? I'm fine with the change in itself, but what should be done is to remove the whole meson_release_flag variable completely. It only existed to serve the transition.
There was a problem hiding this comment.
I think this was ultimately my mistake in c8d0da5, in the sense that the order should have been
meson_release_flag:
- "--buildtype release" # for GCC 12
- "-Dbuildtype=release" # for GCC 13
- "-Dbuildtype=release" # for GCC 14but that was the wrong way around for zipping with
gcc_version:
- 14.1.0
- 13.3.0
- 12.4.0Sorry about that.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)