Skip to content

check in linter for required python run-time dependency #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kain88-de wants to merge 2 commits into from
Closed

check in linter for required python run-time dependency #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f887419
check in linter for required python run-time dependency
kain88-de Jul 17, 2017
9dc2e7b
test for more compilation dependencies
kain88-de Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions conda_smithy/lint_recipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,14 @@ def lintify(meta, recipe_dir=None):
except RuntimeError as e:
lints.append(str(e))

# 13: If cython/numpy is a build-dependency then python should be a run-time
# dependency. This ensures that packages will be marked correctly by conda
build_deps = ['cython', 'numpy x.x']
need_python_run_time = any([dep in requirements_section.get('build', '') for dep in build_deps])
if need_python_run_time and 'python' not in requirements_section.get('run', ''):
lints.append("Found python related compilation requirement "
"please add python as a run-time dependency")

return lints


Expand Down
9 changes: 9 additions & 0 deletions conda_smithy/tests/test_lint_recipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,15 @@ def test_end_empty_line(self):
else:
self.assertIn(expected_message, lints)

def test_implicit_python_run_time_dependency(self):
build_deps = ['cython', 'numpy x.x']
expected_message = ("Found python related compilation requirement "
"please add python as a run-time dependency")
for dep in build_deps:
meta = {'requirements': {'build': [dep, 'python']}}
lints = linter.lintify(meta)
self.assertIn(expected_message, lints)


class TestCLI_recipe_lint(unittest.TestCase):
def test_cli_fail(self):
Expand Down