Fix rendering README#1785
Merged
Merged
Conversation
ocefpaf
approved these changes
Oct 23, 2023
jaimergp
approved these changes
Oct 24, 2023
jaimergp
left a comment
jaimergp
left a comment
Member
There was a problem hiding this comment.
Thanks! Can you add the PR number to the original news item at https://github.com/isuruf/conda-smithy/blob/9b02aa7b17fd2bb40177c9cbd728f46f45ec5b2d/news/1752-readme-channels.rst?plain=1#L7.
Should look like this:
- * Use the channels defined in `conda_build_config.yaml` (instead of those in `conda-forge.yml`) to render `README.md`. (#897 via #752)
+ * Use the channels defined in `conda_build_config.yaml` (instead of those in `conda-forge.yml`) to render `README.md`. (#897 via #1752, #1785)🙏
beckermr
approved these changes
Oct 24, 2023
Member
|
Is there a plan for updating the documentation after this update is released? I didn't see any related Issue or PR on conda-forge.github.io. I can assist with this if needed https://conda-forge.org/docs/maintainer/conda_forge_yml.html#channels |
Member
Author
|
Yes we should open a new PR. A PR or a issue is appreciated. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some bugs from #1752