Changes made to README.md#1690
Conversation
kathatherine
left a comment
kathatherine
left a comment
There was a problem hiding this comment.
Looks good! Just a few changes needed. Let me know if you have any questions.
| 7. ``make html`` | ||
|
|
||
|
|
||
| Conda-forge adheres to the NumFOCUS Code of Conduct. (https://numfocus.org/code-of-conduct) |
There was a problem hiding this comment.
This line has an unnecessary space at the very beginning.
|
|
||
| Conda-forge adheres to the NumFOCUS Code of Conduct. (https://numfocus.org/code-of-conduct) | ||
|
|
||
| ## Scope |
There was a problem hiding this comment.
Unnecessary space here, too. That's probably why the header isn't showing up as blue.
|
|
||
| ## Scope | ||
|
|
||
| This code of conduct applies to all spaces managed by conda-forge, including all public and private mailing lists, issue trackers, wikis, forums, and any other communication channel used by our community. The code of conduct equally applies at conda-forge events and governs standards of behavior for attendees, speakers, volunteers, booth staff, and event sponsors. |
There was a problem hiding this comment.
Unnecessary space here, too.
| - Inappropriate physical contact and/or unwelcome sexual attention or sexual comments | ||
| - Sexist, racist, or otherwise discriminatory jokes and language | ||
| - Trolling or insulting and derogatory comments | ||
| - Written or verbal comments which have the effect of excluding people on the basis of membership in a specific group, including level of experience, gender, gender identity and expression, sexual orientation, disability, neurotype, personal appearance, body size, race, ethnicity, age, religion, or nationality |
There was a problem hiding this comment.
There's a double space between "of" and "experience that doesn't need to be there.
|
|
||
| This code of conduct applies to all spaces managed by conda-forge, including all public and private mailing lists, issue trackers, wikis, forums, and any other communication channel used by our community. The code of conduct equally applies at conda-forge events and governs standards of behavior for attendees, speakers, volunteers, booth staff, and event sponsors. | ||
|
|
||
|
|
There was a problem hiding this comment.
There should only be one blank line in-between sections in this document, instead of two or more, so I'd recommend going through and taking those extra blank lines out.
|
I have made the changes as requested. Since this is my first time contributing to open source, I apologise for all the silly mistakes I made. Thank you for your time :) |
kathatherine
left a comment
kathatherine
left a comment
There was a problem hiding this comment.
Thanks so much! And don't worry about mistakes. This is about you learning and sometimes we learn by doing something wrong first. That's what these reviews are for.
|
Superseded by #1640 |
3 participants
PR Checklist:
srcdirectory, not indocsor in the html files