Skip to content

add migration for pytorch 2.9#7994

Merged
h-vetinari merged 1 commit into
conda-forge:mainfrom
h-vetinari:torch
Nov 26, 2025
Merged

add migration for pytorch 2.9#7994
h-vetinari merged 1 commit into
conda-forge:mainfrom
h-vetinari:torch

Conversation

@h-vetinari
Copy link
Copy Markdown
Member

@h-vetinari h-vetinari requested a review from a team as a code owner November 26, 2025 09:29
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari merged commit c0c16c9 into conda-forge:main Nov 26, 2025
3 checks passed
@h-vetinari h-vetinari deleted the torch branch November 26, 2025 12:52
@hmaarrfk
Copy link
Copy Markdown
Contributor

hm the commit message is mesleading in the yaml

@@ -0,0 +1,10 @@
migrator_ts: 1764149285
__migrator:
commit_message: Rebuild for pytorch 2.8
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste typo...

Suggested change
commit_message: Rebuild for pytorch 2.8
commit_message: Rebuild for pytorch 2.9

@h-vetinari
Copy link
Copy Markdown
Member Author

hm the commit message is misleading in the yaml

yes, sorry about that. It got fixed in #7997

@hmaarrfk
Copy link
Copy Markdown
Contributor

I didn’t know if we could just edit things like that. Thanks.

@h-vetinari
Copy link
Copy Markdown
Member Author

I didn’t know if we could just edit things like that. Thanks.

There are some sensitive things, but the commit message is not among them. We shouldn't change:

  • migrator filename (determines the whole migration)
  • migrator timestamp (determines whether migrator files in feedstock count as "applied")
  • substantially change pins while migration is running

There's some exceptions where the third point can be justified (e.g. to couple two migrations that have log-jammed), but otherwise, the commit message, excxlude: etc. can easily be fixed after the fact, and will be picked up as soon as the new pinning makes it into the lockfile of https://github.com/regro/cf-scripts/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants