Update pin for cfitsio 4.6.2#7238
Conversation
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/cfitsio and so here I am doing that. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/conda-forge-pinning There's already a migration to 4.6.0 partially underway, but we should switch over to this version because 4.6.0 built its pkg-config file in a buggy way. Is that just a matter of deleting the migration file for the 4.6.0 here, or is there something fancier that would need to be done? |
|
The two migrations can run independently from each other - actually I see that there are also open migrations for cfitsio 4.4.1 & 4.5.0. Ideally, you'd pick one of the open migrations, go through the list of open PRs, try to push them over the finish line where possible, and then open a PR to close the migration, noting which stragglers are intentionally ignored. Here's an example of how I'd tackle something like that. Deleting the old migrations should only happen when we actually bump the global pinning to at least that level (because otherwise already-migrated feedstocks would fall down to a previous version upon rerendering). For example, we may be happy to bump to 4.5.0 in the pinning (simultaneously with closing the 4.4.1 & 4.5.0 migrators), and then declare 4.6.0 as superseded by 4.7.0, but delete the 4.6 migrator only when we bump the pinning to 4.7 (this is just a suggestion based on a superficial read of the situation, feel free to pick different waypoints). |
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/cfitsio and so here I am doing that. |
|
The PRs for 4.6 are all roughly 2 weeks old, which isn't that long. But I won't stand in the way here, cleaning up these old migrators is definitely beneficial. Even more so if we keep more on top of them going forward. :) |
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/cfitsio and so here I am doing that. |
This PR has been triggered in an effort to update the pin for cfitsio. The current pinned version is 4.3.1, the latest available version is 4.6.2 and the max pin pattern is x.x.x. This migration will impact 30 feedstocks.
Checklist:
**Please note that if you close this PR we presume that the new pin has been rejected.
@conda-forge-admin please ping cfitsio
This PR was generated by https://github.com/regro/cf-scripts/actions/runs/14234498350 - please use this URL for debugging.